Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for parallel lines in Morris.Grid #103

Merged
merged 1 commit into from
Nov 3, 2012

Conversation

tiraeth
Copy link
Contributor

@tiraeth tiraeth commented Nov 1, 2012

This pull request solves issue #100.

Features:

  • Goals: Values that you want to achieve someday.
  • Events: Time entries that indicates some events over time, e.g. deadlines.

Note: Events works only when @options.parseDate is enabled, thus events works only for time-series charts only.

Events and Goals are implemented in Morris.Grid, so Line, Area, and Bar charts are automatically affected by it (of course, regarding the note above, Events won't work in bar charts).

@oesmith oesmith merged commit 38a1cdd into morrisjs:master Nov 3, 2012
@oesmith
Copy link
Contributor

oesmith commented Nov 3, 2012

Looks good to me 👍

A couple of notes:

  • Math.min / Math.max will treat a null as a zero, so you need to be careful of passing nulls
  • I'm trying to move away from using $.map towards using coffee-script list comprehensions wherever possible (they look tidier to me 😀)

(see 8faced7 for the changes I made when merging)

@tiraeth
Copy link
Contributor Author

tiraeth commented Nov 3, 2012

👍

Coffeescript's reduce is also better than for or $.each in some cases. I used it in Morris.Pie 😀

@dgilperez
Copy link
Contributor

👍

Thanks for this !!! I am happy to see this implemented, really useful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants