Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtilsLib.toUint128 can revert without any error message #394

Closed
Rubilmax opened this issue Aug 21, 2023 · 2 comments · Fixed by #407
Closed

UtilsLib.toUint128 can revert without any error message #394

Rubilmax opened this issue Aug 21, 2023 · 2 comments · Fixed by #407
Assignees

Comments

@Rubilmax
Copy link
Contributor

Rubilmax commented Aug 21, 2023

https://github.com/morpho-labs/morpho-blue/blob/042e224f980314439762c0e213800e91821e0e0a/src/libraries/UtilsLib.sol#L25

I believe having specific error message for each revert branch of our code has a high value to integrators, as they can easily (and almost immediately) identify the source of revert. It will have value to us too, as debuggers in production (indeed, Tenderly does it but deducing the error reason from the error message is faster than having to use a third-party service like Tenderly).

@Rubilmax Rubilmax closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@MathisGD
Copy link
Contributor

Why did you closed ? Especially now that we have explicit over/underflows, it makes sense

@Rubilmax Rubilmax reopened this Aug 21, 2023
@Rubilmax
Copy link
Contributor Author

Why did you closed ? Especially now that we have explicit over/underflows, it makes sense

Didn't saw that, fully agree then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants