-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builder script again #19
Conversation
…to feat/multisend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of adding "a lot" of dependancies to this "critical" repo. I have in mind the arguments of the well known dependancies, of the yarn.lock
, and of the fact that scripts are independent but idk I'm still a little bit less confortable when the dependancies goes to number that I can't quickly "audit". No veto though, if you think that the feature is really worth it.
PS: I didn't review the PR.
The feature solves the following issue:
How would the Morpho DAO pause supply and borrow only for specific (or all) markets otherwise (genuinely asking)? Creating and signing N (nb of markets) txs? We can also export the script to another repository, given it is completely independent from the tx signature scripts |
That a suggestion from @julien-devatom. Should we? |
Let's make it an |
Done: https://github.com/morpho-labs/create-safe-tx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add more information about the dependency? Anyway LGTM
GitHub dropped my work last friday, so here is the true last version of this tool. I am angry.
This PR introduces the
builder
script, which is completely independent from the other scripts already shipped in this repository. Thebuilder
script has nodejs dependencies, but no direct interfaces withforge
scripts are available. Instead, thebuilder
script simply builds atx.json
for the user, who's free to use it or replace it with their own.