Switched boolean flag to immediate flushing to integer #738
Conversation
|
@hylkevds have to do, I'm going with incremental commits, to make it easy reviewable. Still work in progress, once ready I'll ask you as reviewer. |
| if (props.boolProp(BrokerConstants.IMMEDIATE_BUFFER_FLUSH_PROPERTY_NAME, true)) { | ||
| bufferFlushMillis = BrokerConstants.IMMEDIATE_BUFFER_FLUSH; | ||
| } else { | ||
| bufferFlushMillis = BrokerConstants.NO_BUFFER_FLUSH; |
There was a problem hiding this comment.
Maybe it's better to default to the 1s value that used to be used when immediate_buffer_flush was false?
There was a problem hiding this comment.
If you default to 1000ms people coming from Mosquitto will keep reporting bad performance
There was a problem hiding this comment.
The old immediate_buffer_flush default value is now switched from false to true.
So by default it now flushes immediatly, then if the user customize the immediate_buffer_flush to true, the flush interval is 1000ms
There was a problem hiding this comment.
You mean false I presume.immediate False = 1000; immediate true = 0. Explicit numerical value ignored if immediate is true.
…mmediate_buffer_flush'
andsel
force-pushed
the
feature/congurability_of_write_flush_interval
branch
from
9710040
to
09ce6e2
Compare
Release notes
Introduces the ability to specify the flush interval for IO write operations, changing the default, to an immediate flush.
What does it do?
immediate_buffer_flushfrom boolean to a number (expressing milliseconds)buffer_flush_millissettings to initialize the auto flusher.Fixes #718