Fix #583 inflight slots incremented too often #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hylkevds
force-pushed
the
fix_583_inflightSlots_incremented_too_often
branch
from
830bbc9
to
e74af75
Compare
hylkevds
force-pushed
the
fix_583_inflightSlots_incremented_too_often
branch
from
e74af75
to
f4bd776
Compare
Makes sure that messages get added to the inflightTimeouts.
hylkevds
force-pushed
the
fix_583_inflightSlots_incremented_too_often
branch
from
f4bd776
to
d710198
Compare
|
Most of the counting issues were already fixed. |
andsel
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a missed insertion into the timeout counters when messages are drained into a connection
When processing an ACK, the inflightSlots should only be increased if it is the first time the ACK is received for a given message. The ACK may be received multiple times, the subsequent ACKs should not cause the count to be increased.
This PR depends on PR #576 that fixes #573