Fixes #571: ConcurrentModificationException in MemorySubscriptionsRepository #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riptionsRepository The MemorySubscriptionsRepository implementation does not synchronise write access to the subscriptions list. As a result, Iterations over the list will break when another Thread modifies the list. This changes the ArrayList to a ConcurrentSkipListSet and changes the interface of the public List<Subscription> listAllSubscriptions() method to return a Set.
hylkevds
force-pushed
the
fix_571_CME_MemorySubscriptionsRepository
branch
from
2cab11a
to
a84914a
Compare
This was referenced Feb 3, 2021
andsel
requested changes
May 1, 2021
|
|
||
| public class MemorySubscriptionsRepository implements ISubscriptionsRepository { | ||
|
|
||
| private final List<Subscription> subscriptions = new ArrayList<>(); | ||
| private final Set<Subscription> subscriptions = new ConcurrentSkipListSet<>((o1, o2) -> { |
There was a problem hiding this comment.
Instead of providing an explicit comparator is better to implements the Comparable interface, PR for the change is #595
There was a problem hiding this comment.
Yeah, totally agree. Only reason I didn't was to minimise the impact of the PR.
After merging #595, I can either update this PR, or you merge it and then fix the constructor to not supply a Comparator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MemorySubscriptionsRepository implementation does not synchronise
write access to the subscriptions list. As a result, Iterations over the
list will break when another Thread modifies the list.
This changes the ArrayList to a ConcurrentSkipListSet and changes the
interface of the public List listAllSubscriptions() method
to return a Set.