Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keysnail disabled after upgrading firefox #191

Open
redguardtoo opened this issue Jan 29, 2016 · 9 comments
Open

keysnail disabled after upgrading firefox #191

redguardtoo opened this issue Jan 29, 2016 · 9 comments

Comments

@redguardtoo
Copy link

It works by re-install keysnail.xpi.

I suggest keysnail being signed and uploaded to firefox official repository so avoid the annoying warning message.

@caikechao
Copy link

Another problem is that new version firefox (e.g., Firefox 44) does not support old javascript syntax in the .keysnail.js file. I have to recreate the .keysnail.js file after upgrading firefox. Uploading the .xpi file to the official repository might not solve this kind of compatibility problem ...

@redguardtoo
Copy link
Author

@kccai , could you give me some example of old syntax?

@caikechao
Copy link

Keysnail on Firefox 44 keeps prompting the error missing ; if I use the old .keysnail.js file. But on Firefox 43, it works just fine. So I think it might be a js syntax compatibility problem (Sorry, I am not familiar with JavaScript.) So I just diffed the old and the new .keysnail.js files and found the following difference:

In old .keysnail.js, I have

    let (ct = command.getClipboardText()) {
                    (!command.kill.ring.length || ct != command.kill.ring[0]) && command.pushKillRing(ct);
    }

In new .keysnail.js, I have

                let ct = command.getClipboardText();
                if (!command.kill.ring.length || ct != command.kill.ring[0]) {
                    command.pushKillRing(ct);
                }

I do not know whether this is a proper example of old syntax ...

@smallst
Copy link

smallst commented Jan 29, 2016

same here, re-install keysnail and plugins solve the problem but if need reinstall every time after update ff will annoying.

@sepwolves
Copy link

even re-install doesn't resolve the problem, How should I do?

@caikechao
Copy link

@sepwolves What version of Firefox are you using? Keysnail works fine in Firefox 48.0.1 for me.

@sepwolves
Copy link

@kccai me 2. May be there is something wrong. Not all the functions don't work, but some

@sepwolves
Copy link

@kccai 48.0.2 I am not sure whether it is about Firefox.

@sepwolves
Copy link

@kccai In fact, the original function is ok, works well, but the customization is not OK. For example, I define "e" as the function of "select the next tab", but it wouldn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants