Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in config transform to stream service #45

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

pa3ng
Copy link
Contributor

@pa3ng pa3ng commented Aug 11, 2021

Changes

We need to pass in the TransformConfig param as part of the streamService struct

Why Are Changes Being Made

Events being emitted are unencrypted. This patch will properly encrypt events.

@pa3ng pa3ng force-pushed the patch-transform-config-param-passing branch from fc3c81a to 8082644 Compare August 11, 2021 16:52
@codecov-commenter
Copy link

Codecov Report

Merging #45 (8082644) into master (2727383) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   37.18%   37.17%   -0.02%     
==========================================
  Files          78       78              
  Lines        2993     2994       +1     
==========================================
  Hits         1113     1113              
- Misses       1633     1634       +1     
  Partials      247      247              
Impacted Files Coverage Δ
internal/events/service_stream.go 27.27% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2727383...8082644. Read the comment docs.

@pa3ng pa3ng marked this pull request as ready for review August 11, 2021 17:01
@pa3ng pa3ng self-assigned this Aug 11, 2021
@pa3ng pa3ng changed the title Pass in config transfer to stream service Pass in config transform to stream service Aug 11, 2021
@adamdecaf adamdecaf merged commit 67dad63 into master Aug 11, 2021
@adamdecaf adamdecaf deleted the patch-transform-config-param-passing branch August 11, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants