alerting: clean up per pr reviews

internal/alerting/alerter.go

@@ -43,12 +43,12 @@ func NewAlerters(cfg service.ErrorAlerting) (Alerters, error) {
 	return alerters, nil
 }
 
-func (s *Alerters) AlertError(e error) error {
+func (s Alerters) AlertError(e error) error {
 	if e == nil {
 		return nil
 	}
 
-	for _, alerter := range *s {
+	for _, alerter := range s {
 		err := alerter.AlertError(e)
 		if err != nil {
 			return fmt.Errorf("alerting error: %v", err)

internal/alerting/slack.go

@@ -43,26 +43,6 @@ func (s *Slack) AlertError(e error) error {
 	return nil
 }
 
-func (s *Slack) AlertWithAttachments(msg, color string, fields []slack.AttachmentField) error {
-	var attachment = slack.Attachment{
-		Fields: fields,
-		// color hex value, example: "#8E1600"
-		Color: color,
-	}
-
-	_, _, err := s.client.PostMessage(
-		s.channelID,
-		slack.MsgOptionText(msg, false),
-		slack.MsgOptionAttachments(attachment),
-		slack.MsgOptionAsUser(false),
-	)
-	if err != nil {
-		return fmt.Errorf("sending slack message: %v", err)
-	}
-
-	return nil
-}
-
 func (s *Slack) AuthTest() error {
 	if s == nil || s.client == nil {
 		return errors.New("slack: nil or no slack client")

internal/incoming/odfi/scheduler.go

@@ -188,7 +188,7 @@ func (s *PeriodicScheduler) tick(shard *service.Shard) error {
 }
 
 func (s *PeriodicScheduler) alertOnError(err error) {
-	if s == nil || len(s.alerters) == 0 {
+	if s == nil {
 		return
 	}
 	if err == nil {

internal/pipeline/aggregate.go

@@ -362,7 +362,7 @@ func (xfagg *aggregator) notifyAboutHoliday(day *schedule.Day) {
 }
 
 func (xfagg *aggregator) alertOnError(err error) {
-	if xfagg == nil || len(xfagg.alerters) == 0 {
+	if xfagg == nil {
 		return
 	}
 	if err == nil {