Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are ubsan_rt re-exports weak when they could be strong? #1

Open
kubkon opened this issue Aug 16, 2023 · 1 comment
Open

Why are ubsan_rt re-exports weak when they could be strong? #1

kubkon opened this issue Aug 16, 2023 · 1 comment

Comments

@kubkon
Copy link

kubkon commented Aug 16, 2023

Is there any reason why you are re-exporting symbols that appear to always be unique as .Weak instead of .Strong? Do envision them being overloadable?

const linkage: std.builtin.GlobalLinkage = if (builtin.is_test) .Internal else .Weak;

@moosichu
Copy link
Owner

It's because the implementation is derived from: ziglang/zig#5165, and I haven't looked at that side of things myself yet to see what is appropriate. @LemonBoy is there a specific reason why the symbols are weak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants