-
Notifications
You must be signed in to change notification settings - Fork 341
web version #112
Comments
Had a good time tonight playing with this :) code is at https://github.com/Flet/friends/tree/web
I think the ghsign stuff could totally be pulled out of @beaugunderson I ran into this error coming back from your signalhub... may need some CORS headers:
|
Wow @Flet! Nice work! :D |
Wow its working through the Evil Corporate Proxy too heh 👍 |
@maxogden is it possible to add CORS header to signalhub.publicbits.org?
|
Interested in contributing -- let me know where we are at after flet's work and what piece I could bite off |
Excellent! :) I think #129 and also moving swarm to its own module tick a few of @shama's boxes above.
|
@Flet i just added more cors headers to signalhub https://github.com/maxogden/dat/blob/master/lib/rest-server.js#L9-L14 and upgraded it on my server, lemme know if it works now |
Doesn't appear to be an issue anymore for me either. |
@maxogden cool, its looking good now! |
ah, @maxogden I may have spoken too soon... I get a 502 from nginx when hitting https://signalhub.publicbits.org/ (instead of the name/version json). |
oops my bad, apparently I didn't have it set to start on reboot On Sat, May 23, 2015 at 1:23 PM, Dan Flettre [email protected]
|
I just pushed a bunch of changes to make it work in the browser. Thanks @Flet - your code was really handy for that. |
`request` doesn’t work well in the browser per #112 so removed it in favor of `simple-get` This also fixes a race condition during `npm install` that is probably caused by some dependency’s postinstall script expecting request to be fully installed, but it’s not because it’s hoisted to the top level node_modules.
Cool! But also I really hate the proxy situation in node.js... I wish it could be handled by node itself :( |
@Flet Could you elaborate? I don't understand the web proxy issue. |
Sure! The In the browsers this really is not an issue as all browser allow proxies to be configured. For node however, core does not do any proxying. Related node issue nodejs/node#1490 -- doing something like Some of sindresorhus' packages use his cool little |
For |
Tracking what's need for a web version:
brfs
is having issues withprotocol-buffer
ghsign
relies on the filesystem and usesrequest
which isn't web compatweb.js
swarm.js
shouldn't rely on the file systemThe text was updated successfully, but these errors were encountered: