The order of Shell::get_profile_paths is not consistent among shells; unify and clarify it

[tats-u]

• Don't newly create .bash_profile #105 (comment)
• The most preferred profile file comes last in setup proto#655

In Bash, the most preferred profile (not rc) comes first:

starbase/crates/shell/src/shells/bash.rs

Lines 17 to 30 in 9f20f1b

	fn has_bash_profile(home_dir: &Path) -> bool {
	home_dir.join(".bash_profile").exists()
	}
	fn profile_for_bash(home_dir: &Path) -> PathBuf {
	// https://github.com/moonrepo/starbase/issues/99
	// Ubuntu doesn't have .bash_profile. It uses .profile instead.
	// If .bash_profile is newly created, .profile will be no longer loaded.
	if has_bash_profile(home_dir) {
	home_dir.join(".bash_profile")
	} else {
	home_dir.join(".profile")
	}
	}

starbase/crates/shell/src/shells/bash.rs

Lines 87 to 106 in 9f20f1b

	fn get_config_path(&self, home_dir: &Path) -> PathBuf {
	profile_for_bash(home_dir)
	}
	fn get_env_path(&self, home_dir: &Path) -> PathBuf {
	profile_for_bash(home_dir)
	}
	fn get_profile_paths(&self, home_dir: &Path) -> Vec<PathBuf> {
	if has_bash_profile(home_dir) {
	vec![
	home_dir.join(".bash_profile"),
	home_dir.join(".bashrc"),
	home_dir.join(".profile"),
	]
	} else {
	// Default .profile calls .bashrc in Ubuntu
	vec![home_dir.join(".profile"), home_dir.join(".bashrc")]
	}
	}

In elvish, the most preferred one returned by get_config_path comes first while the "legacy" one comes last:

starbase/crates/shell/src/shells/elvish.rs

Lines 88 to 102 in 9f20f1b

	fn get_config_path(&self, home_dir: &Path) -> PathBuf {
	get_config_dir(home_dir).join("elvish").join("rc.elv")
	}
	fn get_env_path(&self, home_dir: &Path) -> PathBuf {
	self.get_config_path(home_dir)
	}
	fn get_profile_paths(&self, home_dir: &Path) -> Vec<PathBuf> {
	#[allow(unused_mut)]
	let mut profiles = HashSet::<PathBuf>::from_iter([
	get_config_dir(home_dir).join("elvish").join("rc.elv"),
	home_dir.join(".config").join("elvish").join("rc.elv"),
	home_dir.join(".elvish").join("rc.elv"), // Legacy
	]);

In fish, the return value of get_config_path comes first in get_profile_paths like the above 2 shells:

starbase/crates/shell/src/shells/fish.rs

Lines 64 to 79 in 9f20f1b

	fn get_config_path(&self, home_dir: &Path) -> PathBuf {
	get_config_dir(home_dir).join("fish").join("config.fish")
	}
	fn get_env_path(&self, home_dir: &Path) -> PathBuf {
	self.get_config_path(home_dir)
	}
	fn get_profile_paths(&self, home_dir: &Path) -> Vec<PathBuf> {
	HashSet::<PathBuf>::from_iter([
	get_config_dir(home_dir).join("fish").join("config.fish"),
	home_dir.join(".config").join("fish").join("config.fish"),
	])
	.into_iter()
	.collect()
	}

However, in nushell, the order depends on the hash algorithm of HashSet:

starbase/crates/shell/src/shells/nu.rs

Lines 132 to 150 in 9f20f1b

	fn get_config_path(&self, home_dir: &Path) -> PathBuf {
	get_config_dir(home_dir).join("nushell").join("config.nu")
	}
	fn get_env_path(&self, home_dir: &Path) -> PathBuf {
	get_config_dir(home_dir).join("nushell").join("env.nu")
	}
	// https://www.nushell.sh/book/configuration.html
	fn get_profile_paths(&self, home_dir: &Path) -> Vec<PathBuf> {
	HashSet::<PathBuf>::from_iter([
	get_config_dir(home_dir).join("nushell").join("env.nu"),
	home_dir.join(".config").join("nushell").join("env.nu"),
	get_config_dir(home_dir).join("nushell").join("config.nu"),
	home_dir.join(".config").join("nushell").join("config.nu"),
	])
	.into_iter()
	.collect()
	}

Proto treats the return value of get_profile_paths as least-preferred-comes-first, but its assumption is basically wrong.
Starbase needs to unify and clarify the order of get_profile_paths.

[milesj]

"Profile" paths can be either profile or rc files, it's not just literal profiles. I couldn't think of a better name (naming is hard lol).

I'll fix the ordering though.