chore: fixes clippy redundant_closure_call error inside macros #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B0-silent
RomarQ
requested review from
noandrea,
links234,
librelois,
timbrinded and
ahmadkaouk
Coverage Report@@ Coverage Diff @@
## master rq/fix-clippy-issue +/- ##
======================================================
Coverage 80.91% 80.91% 0.00%
Files 287 287
+ Lines 94502 94503 +1
======================================================
+ Hits 76460 76461 +1
Misses 18042 18042
|
librelois
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pipeline.
Clippy reports
redundant_closure_callin mock_account macro. It could be implemented differently as we can see in the macro expansions bellow, but is easier and readable as it currently is.The error can be ignored: rust-lang/rust-clippy#1553
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?