Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpeningBraceSameLineSniff does not seem in use for classes #168

Closed
kabalin opened this issue Jan 4, 2022 · 0 comments · Fixed by #170
Closed

OpeningBraceSameLineSniff does not seem in use for classes #168

kabalin opened this issue Jan 4, 2022 · 0 comments · Fixed by #170

Comments

@kabalin
Copy link
Member

kabalin commented Jan 4, 2022

As result, it does not complain on violations similar to

class api
{

or when there are spaces before or after brace

class api       {

Issue has been found by @dravek (thanks!)
kabalin added a commit to kabalin/moodle-local_codechecker that referenced this issue Jan 4, 2022
@kabalin
Use Generic.Classes.OpeningBraceSameLine sniff
6b8faa4 
This implmements validation of use of curly braces in class declaration.

Fixes moodlehq#168
@kabalin kabalin mentioned this issue Jan 4, 2022
Merged
kabalin added a commit to kabalin/moodle-local_codechecker that referenced this issue Jan 4, 2022
@kabalin
Use Generic.Classes.OpeningBraceSameLine sniff
f73ee94 
This implmements validation of use of curly braces in class declaration.

Fixes moodlehq#168
kabalin added a commit to kabalin/moodle-local_codechecker that referenced this issue Jan 4, 2022
@kabalin
Use Generic.Classes.OpeningBraceSameLine sniff
ab92533 
This implmements validation of use of curly braces in class declaration.

Fixes moodlehq#168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Generic.Classes.OpeningBraceSameLine sniff kabalin/moodle-local_codechecker
1 participant
@kabalin