Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SVG logos are broken on latest Moodle releases #733

Open
abias opened this issue Oct 21, 2024 · 4 comments
Open

Bug: SVG logos are broken on latest Moodle releases #733

abias opened this issue Oct 21, 2024 · 4 comments
Assignees
Labels
bug Something which isn't working

Comments

@abias
Copy link
Member

abias commented Oct 21, 2024

As it seems, Boost Union's support for SVG logos is broken on latest Moodle releases:

grafik
@abias abias added the bug Something which isn't working label Oct 21, 2024
@abias abias self-assigned this Oct 21, 2024
@rlgh770
Copy link

rlgh770 commented Oct 22, 2024

does this cause the problem I am seeing here:
image

@abias
Copy link
Member Author

abias commented Oct 23, 2024

@rlgh770 - your screenshot is rather unclear to me as it is just a fragment of a Moodle page. Please post a full screenshot to allow us to investigate it.

Nevertheless, I do not think that your issue is related to the issue which is reported here and which targets the logo in the navbar.

@abias
Copy link
Member Author

abias commented Oct 23, 2024

Note:
This issue seems to affect only Firefox, on Chrome and Safari (all on Mac) the SVG icon is displayed properly near the main navigation.

@abias abias moved this to In Progress DEV in Boost Union Planning Board Oct 23, 2024
@abias
Copy link
Member Author

abias commented Oct 24, 2024

Comparing the overall page's HTML code in Moodle 4.1 and 4.5, I saw that in 4.5 there is an additional container-fluid element in the navbar:

grafik

As a result, the navbar in 4.5 is now a flexbox construction while in 4.1 it was not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something which isn't working
Projects
Status: In Progress DEV
Development

No branches or pull requests

2 participants