From f42e9c3c06e1591edfc1453046695bf2ab61081b Mon Sep 17 00:00:00 2001
From: Alexander Bias <bias@alexanderbias.de>
Date: Thu, 6 Jun 2024 07:22:37 +0200
Subject: [PATCH] Cleanup: Fix 'Implicitly marking a parameter as nullable is
 deprecated since PHP 8.4' codechecker warning, resolves #667. (#668)

---
 CHANGES.md                 |  1 +
 classes/smartmenu_item.php | 14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/CHANGES.md b/CHANGES.md
index 58affe48983..a443a4d186b 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased 
 
+* 2024-05-05 - Cleanup: Fix 'Implicitly marking a parameter as nullable is deprecated since PHP 8.4' codechecker warning, resolves #667.
 * 2024-04-28 - Feature: Allow admins to configure URLs from where Boost Union will fetch additional raw SCSS code, resolves #41.
 * 2024-05-13 - Improvement: Suppress icons in footer, resolves #649
 * 2024-05-13 - Bugfix: Make the "More menu behavior" setting in smart menus more stable, resolves #461.
diff --git a/classes/smartmenu_item.php b/classes/smartmenu_item.php
index 1527ce67b4c..394e13e4c49 100644
--- a/classes/smartmenu_item.php
+++ b/classes/smartmenu_item.php
@@ -270,7 +270,7 @@ class smartmenu_item {
      * @param stdclass|null $menu Data of the menu the item belongs to.
      * @return smartmenu_item A new instance of this class.
      */
-    public static function instance($item, $menu=null) {
+    public static function instance($item, $menu = null) {
         return new self($item, $menu);
     }
 
@@ -281,7 +281,7 @@ public static function instance($item, $menu=null) {
      * @param int|stdclass $item Record or id of the menu.
      * @param stdclass|null $menu Menu data belongs to this item, it fetch the menus data if empty.
      */
-    public function __construct($item, $menu=null) {
+    public function __construct($item, $menu = null) {
 
         if (is_scalar($item)) {
             $item = $this->get_item($item);
@@ -331,7 +331,7 @@ public function delete_cache() {
      * @return \stdclass Menu record if found or false.
      * @throws \moodle_exception When menu is not found.
      */
-    public function get_item($itemid=null) {
+    public function get_item($itemid = null) {
         global $DB;
 
         // Verfiy and Fetch menu record from DB.
@@ -1114,8 +1114,8 @@ public function build() {
      *
      * @return array An associative array of node data for the item.
      */
-    public function generate_node_data($title, $url, $key=null, $tooltip=null,
-        $itemtype='link', $haschildren=0, $children=[], $itemimage='', $sortstring='') {
+    public function generate_node_data($title, $url, $key = null, $tooltip = null,
+        $itemtype = 'link', $haschildren = 0, $children = [], $itemimage = '', $sortstring = '') {
 
         global $OUTPUT;
 
@@ -1318,7 +1318,7 @@ public static function load_custom_field_config(&$mform) {
      * @param int|null $type Optional. The specific type to retrieve. Defaults to null.
      * @return array|string An array of types if $type is null, or a string with the name of the specific type.
      */
-    public static function get_types(int $type=null) {
+    public static function get_types(?int $type = null) {
         $types = [
                 self::TYPESTATIC => get_string('smartmenusmenuitemtypestatic', 'theme_boost_union'),
                 self::TYPEHEADING => get_string('smartmenusmenuitemtypeheading', 'theme_boost_union'),
@@ -1335,7 +1335,7 @@ public static function get_types(int $type=null) {
      * @return array|string The array of display options if $option is null, or the display option string if $option is set.
      * @throws coding_exception if $option is set but invalid.
      */
-    public static function get_display_options(int $option=null) {
+    public static function get_display_options(?int $option = null) {
         $displayoptions = [
                 self::DISPLAY_SHOWTITLEICON => get_string('smartmenusmenuitemdisplayoptionsshowtitleicon', 'theme_boost_union'),
                 self::DISPLAY_HIDETITLE => get_string('smartmenushidetitle', 'theme_boost_union'),