Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep-alive.js from Vue #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pavel-ignatovich
Copy link

@pavel-ignatovich pavel-ignatovich added Demonstration JS Files in JavaScript labels Jan 12, 2020
Copy link

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated code-style review, new suggestions: 5

max: [String, Number]
},

created () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
created () {
created() {

This comment was generated with the following checker: FixMyJS

this.keys = []
},

destroyed () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
destroyed () {
destroyed() {

This comment was generated with the following checker: FixMyJS

}
},

mounted () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mounted () {
mounted() {

This comment was generated with the following checker: FixMyJS

})
},

render () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
render () {
render() {

This comment was generated with the following checker: FixMyJS

cache[key] = vnode
keys.push(key)
// prune oldest entry
if (this.max && keys.length > parseInt(this.max)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (this.max && keys.length > parseInt(this.max)) {
if (this.max && keys.length > parseInt(this.max, 10)) {

This comment was generated with the following checker: FixMyJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Demonstration JS Files in JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant