-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep-alive.js from Vue #20
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is autogenerated code-style review, new suggestions: 5
max: [String, Number] | ||
}, | ||
|
||
created () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created () { | |
created() { |
This comment was generated with the following checker: FixMyJS
this.keys = [] | ||
}, | ||
|
||
destroyed () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
destroyed () { | |
destroyed() { |
This comment was generated with the following checker: FixMyJS
} | ||
}, | ||
|
||
mounted () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mounted () { | |
mounted() { |
This comment was generated with the following checker: FixMyJS
}) | ||
}, | ||
|
||
render () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
render () { | |
render() { |
This comment was generated with the following checker: FixMyJS
cache[key] = vnode | ||
keys.push(key) | ||
// prune oldest entry | ||
if (this.max && keys.length > parseInt(this.max)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.max && keys.length > parseInt(this.max)) { | |
if (this.max && keys.length > parseInt(this.max, 10)) { |
This comment was generated with the following checker: FixMyJS
src/core/components/keep-alive.js from https://github.com/vuejs/vue/blob/215f877/src/core/components/keep-alive.js