Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation clarification of mono_method_desc_new #613

Open
mickeyordog opened this issue May 5, 2023 · 1 comment
Open

Documentation clarification of mono_method_desc_new #613

mickeyordog opened this issue May 5, 2023 · 1 comment

Comments

@mickeyordog
Copy link

Hi, I'd like to request that either this is clarified in the documentation. On this page here, it mentions that you can pass e.g. “System.Object:GetHashCode()” into mono_method_desc_new() to help you search for a method. I think it would be helpful to clarify that you also need to specify what arguments the function takes. For example, if this function took an int parameter, it would need to say “System.Object:GetHashCode(int)”. A lot of the info at the top of here should probably also be mentioned. In particular the fact that floats need to be written as "single" to find the correct method.

I also think it should be mentioned that mono_method_desc_new() allocates memory and needs to be freed with mono_method_desc_free(). I'm unsure if mono_jit_cleanup () will automatically get rid of allocated mono memory and would appreciate this being cleared up.

@akoeplinger
Copy link
Member

We'd be happy to accept a pull request which improves the page, you can do so by clicking on the Edit page on GitHub link at the top of the page which will take you to the source: https://github.com/mono/website/blob/gh-pages/docs/advanced/embedding/index.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants