-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third-party (DevExpress) DLLs not being trimmed #772
Comments
Could you please attach or link the project which reproduces this behaviour? |
Hi @marek-safar, please see the latest comment from DevExpress here (very bottom). |
Are you using: |
@zezba9000 Yup - I know about that setting, and that it does indeed increase sizes further. It's not quite related to this issue since this is about DLLs not being trimmed / unnecessary ones being included. @marek-safar Let me know if you need anything else that may help. |
a repro using newtonsoft new console app:
no code in the program.cs
Newtonsoft.Json.dll is still in the publish dir |
Hi! With .NET 5 development well underway, what can be expected on this front? |
@marek-safar should this still have the "needs more info" label? |
DevExpress libraries will most likely have to be validated for .NET5 to see if they are using any linker incompatible APIs |
@marek-safar shouldnt a consumer be allowed to opt in to trim any dlls they want? |
They will most likely be able to do that in .net 5 as well |
This has been improved in .NET 6+. See the available options here: https://docs.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options |
When using the PublishTrimmed setting on a .NET Core 3.0 WinForms project, combined with the DevExpress.WindowsDesktop.Win NuGet package, the entirety of that package gets bundled with the app, despite the PublishTrimmed setting. That is around 150 MB, most of which probably is not required at all.
DevExpress is aware of the problem and has determined that any fixes will need to go into .NET Core/linker. I hope you will consider improving the trimming feature in the near future, as huge WinForms apps are not particularly enticing right now.
DevExpress ticket for reference
The text was updated successfully, but these errors were encountered: