From f7c0511d17d653444cfc6c451e4efb2557d6a380 Mon Sep 17 00:00:00 2001
From: Matthew Leibowitz <mattleibow@live.com>
Date: Thu, 14 Jul 2022 00:55:08 +0200
Subject: [PATCH] Revert "Rename IsCompleted to IsRunning (#127)"

This reverts commit ce6c5c03f322a120d881b8311431f3b7a54e3c84.
---
 docs/api/ui-forms/skconfettiview.md           |  6 +--
 docs/api/ui-forms/sklottieview.md             |  2 +-
 docs/api/ui-maui/skconfettiview.md            |  7 ++--
 docs/api/ui-maui/sklottieview.md              |  2 +-
 .../Converters/InvertedBooleanConverter.cs    | 18 ---------
 .../Demos/Confetti/ConfettiPage.xaml          |  7 +---
 .../Demos/Lottie/LottiePage.xaml              |  8 +---
 .../Converters/InvertedBoolConverter.cs       | 16 --------
 .../Demos/Confetti/ConfettiPage.xaml          |  7 +---
 .../Demos/Lottie/LottiePage.xaml              |  7 +---
 .../Confetti/SKConfettiEmitter.shared.cs      | 33 ++++++---------
 .../Confetti/SKConfettiParticle.shared.cs     | 10 ++---
 .../Confetti/SKConfettiSystem.shared.cs       | 33 ++++++++-------
 .../Confetti/SKConfettiView.shared.cs         | 40 ++++++++-----------
 .../Controls/Lottie/SKLottieView.shared.cs    | 25 ++++++------
 .../Confetti/SKConfettiEmitterTest.cs         | 30 +++++++-------
 .../Controls/Confetti/SKConfettiSystemTest.cs | 11 ++---
 17 files changed, 95 insertions(+), 167 deletions(-)
 delete mode 100644 samples/Forms/SkiaSharpDemo/Converters/InvertedBooleanConverter.cs
 delete mode 100644 samples/Maui/SkiaSharpDemo/Converters/InvertedBoolConverter.cs

diff --git a/docs/api/ui-forms/skconfettiview.md b/docs/api/ui-forms/skconfettiview.md
index e4772d21..48527ac3 100644
--- a/docs/api/ui-forms/skconfettiview.md
+++ b/docs/api/ui-forms/skconfettiview.md
@@ -14,7 +14,7 @@ The main property of a confetti view is the `Systems` property:
 | :--------------------- | :---------------------------- | :---------- |
 | **Systems**            | `SKConfettiSystemCollection`  | The collection of [systems](#system) in the view. |
 | **IsAnimationEnabled** | `bool`                        | Determines whether the control will play the animation provided. |
-| **IsRunning**          | `bool`                        | Determines whether the control is currently rendering confetti. |
+| **IsComplete**         | `bool`                        | A value that indicates whether all systems are complete. |
 
 ## Parts
 
@@ -52,7 +52,7 @@ Every confetti view consists up one or more systems (`SKConfettiSystem`). Each s
 | **FadeOut**                   | `bool`                         | Whether or not the particle should fade out at the end of its life. |
 | **Lifetime**                  | `double`                       | The duration in seconds for how long the particle is allowed to live. |
 | **IsAnimationEnabled**        | `bool`                         | Controls whether the system is running or not. |
-| **IsRunning**                 | `bool`                         | Determines whether the system is complete and all systems and particles are also complete. |
+| **IsComplete**                | `bool`                         | A value that indicates whether the system is complete and all systems and particles are also complete. |
 
 # Emitter
 
@@ -63,7 +63,7 @@ Each system has an emitter instance that controls how the confetti particles are
 | **ParticleRate**  | `int`     | The number of particles to generate each second. |
 | **MaxParticles**  | `int`     | The maximum number of particles allowed by the emitter. A value of `-1` indicates no limit. |
 | **Duration**      | `double`  | The duration in seconds of how long the emitter runs for. A value of `0` indicates that all particles are emitted instantly. |
-| **IsRunning**     | `bool`    | Determines whether the emitter has generated all the particles and they have all disappeared. |
+| **IsComplete**    | `bool`    | A value that indicates whether the emitter has generated all the particles and they have all disappeared. |
 
 ## Helper Emitters
 
diff --git a/docs/api/ui-forms/sklottieview.md b/docs/api/ui-forms/sklottieview.md
index 274d1302..4d7567d8 100644
--- a/docs/api/ui-forms/sklottieview.md
+++ b/docs/api/ui-forms/sklottieview.md
@@ -18,7 +18,7 @@ There are several properties that can be used to control th animation playback:
 | **RepeatCount**        | `int`                  | The number of times to repeat the animation. Default is 0 (no repeat). |
 | **RepeatMode**         | `SKLottieRepeatMode`   | The way in which to repeat the animation. Default is `Restart`. |
 | **IsAnimationEnabled** | `bool`                 | Determines whether the control will play the animation provided. |
-| **IsRunning**          | `bool`                 | Determines whether the control is currently rendering the animation. |
+| **IsComplete**         | `bool`                 | A value that indicates whether all systems are complete. |
 
 ## Events
 
diff --git a/docs/api/ui-maui/skconfettiview.md b/docs/api/ui-maui/skconfettiview.md
index 6c6b239d..48527ac3 100644
--- a/docs/api/ui-maui/skconfettiview.md
+++ b/docs/api/ui-maui/skconfettiview.md
@@ -14,7 +14,7 @@ The main property of a confetti view is the `Systems` property:
 | :--------------------- | :---------------------------- | :---------- |
 | **Systems**            | `SKConfettiSystemCollection`  | The collection of [systems](#system) in the view. |
 | **IsAnimationEnabled** | `bool`                        | Determines whether the control will play the animation provided. |
-| **IsRunning**          | `bool`                        | Determines whether the control is currently rendering confetti. |
+| **IsComplete**         | `bool`                        | A value that indicates whether all systems are complete. |
 
 ## Parts
 
@@ -52,7 +52,7 @@ Every confetti view consists up one or more systems (`SKConfettiSystem`). Each s
 | **FadeOut**                   | `bool`                         | Whether or not the particle should fade out at the end of its life. |
 | **Lifetime**                  | `double`                       | The duration in seconds for how long the particle is allowed to live. |
 | **IsAnimationEnabled**        | `bool`                         | Controls whether the system is running or not. |
-| **IsRunning**                 | `bool`                         | Determines whether the system is complete and all systems and particles are also complete. |
+| **IsComplete**                | `bool`                         | A value that indicates whether the system is complete and all systems and particles are also complete. |
 
 # Emitter
 
@@ -63,8 +63,7 @@ Each system has an emitter instance that controls how the confetti particles are
 | **ParticleRate**  | `int`     | The number of particles to generate each second. |
 | **MaxParticles**  | `int`     | The maximum number of particles allowed by the emitter. A value of `-1` indicates no limit. |
 | **Duration**      | `double`  | The duration in seconds of how long the emitter runs for. A value of `0` indicates that all particles are emitted instantly. |
-| **IsRunning**     | `bool`    | Determines whether the control is currently rendering confetti. |
-| **IsRunning**     | `bool`    | Determines whether the emitter has generated all the particles and they have all disappeared. |
+| **IsComplete**    | `bool`    | A value that indicates whether the emitter has generated all the particles and they have all disappeared. |
 
 ## Helper Emitters
 
diff --git a/docs/api/ui-maui/sklottieview.md b/docs/api/ui-maui/sklottieview.md
index 274d1302..4d7567d8 100644
--- a/docs/api/ui-maui/sklottieview.md
+++ b/docs/api/ui-maui/sklottieview.md
@@ -18,7 +18,7 @@ There are several properties that can be used to control th animation playback:
 | **RepeatCount**        | `int`                  | The number of times to repeat the animation. Default is 0 (no repeat). |
 | **RepeatMode**         | `SKLottieRepeatMode`   | The way in which to repeat the animation. Default is `Restart`. |
 | **IsAnimationEnabled** | `bool`                 | Determines whether the control will play the animation provided. |
-| **IsRunning**          | `bool`                 | Determines whether the control is currently rendering the animation. |
+| **IsComplete**         | `bool`                 | A value that indicates whether all systems are complete. |
 
 ## Events
 
diff --git a/samples/Forms/SkiaSharpDemo/Converters/InvertedBooleanConverter.cs b/samples/Forms/SkiaSharpDemo/Converters/InvertedBooleanConverter.cs
deleted file mode 100644
index 017ce72e..00000000
--- a/samples/Forms/SkiaSharpDemo/Converters/InvertedBooleanConverter.cs
+++ /dev/null
@@ -1,18 +0,0 @@
-using System;
-using System.Globalization;
-using Xamarin.Forms;
-
-namespace SkiaSharpDemo.Converters
-{
-	public class InvertedBooleanConverter : IValueConverter
-	{
-		public object Convert(object value, Type targetType, object parameter, CultureInfo culture) =>
-			value switch
-			{
-				bool b => !b,
-				_ => throw new ArgumentException("Value was not a bool.", nameof(value)),
-			};
-
-		public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) => Convert(value, targetType, parameter, culture);
-	}
-}
diff --git a/samples/Forms/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml b/samples/Forms/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml
index d68ec70e..c331e5ce 100644
--- a/samples/Forms/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml
+++ b/samples/Forms/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml
@@ -1,15 +1,10 @@
 <ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
              xmlns:controls="clr-namespace:SkiaSharp.Extended.UI.Controls;assembly=SkiaSharp.Extended.UI"
-             xmlns:converters="clr-namespace:SkiaSharpDemo.Converters"
              xmlns:views="clr-namespace:SkiaSharpDemo.Views"
              x:Class="SkiaSharpDemo.Demos.ConfettiPage"
              Title="Confetti">
 
-    <ContentPage.Resources>
-        <converters:InvertedBooleanConverter x:Key="InvertedBooleanConverter" />
-    </ContentPage.Resources>
-
     <Grid>
 
         <Label Text="{Binding Message}" FontSize="32" FontAttributes="Bold"
@@ -25,7 +20,7 @@
         <BoxView Color="Green" Opacity="0.5" CornerRadius="12"
                  WidthRequest="25" HeightRequest="24" Margin="24"
                  HorizontalOptions="End" VerticalOptions="Start"
-                 IsVisible="{Binding IsRunning, Source={Reference confettiView}, Converter={StaticResource InvertedBooleanConverter}}" />
+                 IsVisible="{Binding IsComplete, Source={Reference confettiView}}" />
 
         <views:BottomTabBar SelectedIndex="{Binding SelectedTab}" PagePadding="12,6">
             <views:BottomTabCollection>
diff --git a/samples/Forms/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml b/samples/Forms/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml
index 2cc49e71..277cf126 100644
--- a/samples/Forms/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml
+++ b/samples/Forms/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml
@@ -1,14 +1,10 @@
 <ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
              xmlns:controls="clr-namespace:SkiaSharp.Extended.UI.Controls;assembly=SkiaSharp.Extended.UI"
-             xmlns:converters="clr-namespace:SkiaSharpDemo.Converters"
+             xmlns:views="clr-namespace:SkiaSharpDemo.Views"
              x:Class="SkiaSharpDemo.Demos.LottiePage"
              Title="Lottie">
 
-    <ContentPage.Resources>
-        <converters:InvertedBooleanConverter x:Key="InvertedBooleanConverter" />
-    </ContentPage.Resources>
-
     <Grid RowDefinitions="*,Auto">
 
         <controls:SKLottieView x:Name="lottieView"
@@ -20,7 +16,7 @@
         <BoxView Color="Green" Opacity="0.5" CornerRadius="12"
                  WidthRequest="25" HeightRequest="24" Margin="24"
                  HorizontalOptions="End" VerticalOptions="Start"
-                 IsVisible="{Binding IsRunning, Source={Reference confettiView}, Converter={StaticResource InvertedBooleanConverter}}" />
+                 IsVisible="{Binding IsComplete, Source={Reference lottieView}}" />
 
         <StackLayout Spacing="12" Padding="12" Grid.Row="1">
 
diff --git a/samples/Maui/SkiaSharpDemo/Converters/InvertedBoolConverter.cs b/samples/Maui/SkiaSharpDemo/Converters/InvertedBoolConverter.cs
deleted file mode 100644
index 020903f6..00000000
--- a/samples/Maui/SkiaSharpDemo/Converters/InvertedBoolConverter.cs
+++ /dev/null
@@ -1,16 +0,0 @@
-using System.Globalization;
-
-namespace SkiaSharpDemo.Converters
-{
-	public class InvertedBooleanConverter : IValueConverter
-	{
-		public object Convert(object value, Type targetType, object parameter, CultureInfo culture) =>
-			value switch
-			{
-				bool b => !b,
-				_ => throw new ArgumentException("Value was not a bool.", nameof(value)),
-			};
-
-		public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) => Convert(value, targetType, parameter, culture);
-	}
-}
diff --git a/samples/Maui/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml b/samples/Maui/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml
index d495ecff..8257888a 100644
--- a/samples/Maui/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml
+++ b/samples/Maui/SkiaSharpDemo/Demos/Confetti/ConfettiPage.xaml
@@ -1,15 +1,10 @@
 <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
              xmlns:controls="clr-namespace:SkiaSharp.Extended.UI.Controls;assembly=SkiaSharp.Extended.UI"
-             xmlns:converters="clr-namespace:SkiaSharpDemo.Converters"
              xmlns:views="clr-namespace:SkiaSharpDemo.Views"
              x:Class="SkiaSharpDemo.Demos.ConfettiPage"
              Title="Confetti">
 
-    <ContentPage.Resources>
-        <converters:InvertedBooleanConverter x:Key="InvertedBooleanConverter" />
-    </ContentPage.Resources>
-    
     <Grid>
 
         <Label Text="{Binding Message}" FontSize="32" FontAttributes="Bold"
@@ -25,7 +20,7 @@
         <BoxView Color="Green" Opacity="0.5" CornerRadius="12"
                  WidthRequest="25" HeightRequest="24" Margin="24"
                  HorizontalOptions="End" VerticalOptions="Start"
-                 IsVisible="{Binding IsRunning, Source={Reference confettiView}, Converter={StaticResource InvertedBooleanConverter}}" />
+                 IsVisible="{Binding IsComplete, Source={Reference confettiView}}" />
 
         <views:BottomTabBar SelectedIndex="{Binding SelectedTab}" PagePadding="12,6">
             <views:BottomTabCollection>
diff --git a/samples/Maui/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml b/samples/Maui/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml
index 145b049b..5d1a4935 100644
--- a/samples/Maui/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml
+++ b/samples/Maui/SkiaSharpDemo/Demos/Lottie/LottiePage.xaml
@@ -1,15 +1,10 @@
 <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
              xmlns:controls="clr-namespace:SkiaSharp.Extended.UI.Controls;assembly=SkiaSharp.Extended.UI"
-             xmlns:converters="clr-namespace:SkiaSharpDemo.Converters"
              xmlns:views="clr-namespace:SkiaSharpDemo.Views"
              x:Class="SkiaSharpDemo.Demos.LottiePage"
              Title="Lottie">
 
-    <ContentPage.Resources>
-        <converters:InvertedBooleanConverter x:Key="InvertedBooleanConverter" />
-    </ContentPage.Resources>
-
     <Grid RowDefinitions="*,Auto">
 
         <controls:SKLottieView x:Name="lottieView"
@@ -23,7 +18,7 @@
         <BoxView Color="Green" Opacity="0.5" CornerRadius="12"
                  WidthRequest="25" HeightRequest="24" Margin="24"
                  HorizontalOptions="End" VerticalOptions="Start"
-                 IsVisible="{Binding IsRunning, Source={Reference confettiView}, Converter={StaticResource InvertedBooleanConverter}}" />
+                 IsVisible="{Binding IsComplete, Source={Reference lottieView}}" />
 
         <VerticalStackLayout Spacing="12" Padding="12" Grid.Row="1">
 
diff --git a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiEmitter.shared.cs b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiEmitter.shared.cs
index 25e47819..e3570d4e 100644
--- a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiEmitter.shared.cs
+++ b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiEmitter.shared.cs
@@ -22,14 +22,13 @@ public class SKConfettiEmitter : BindableObject
 			typeof(SKConfettiEmitter),
 			5.0);
 
-		private static readonly BindablePropertyKey IsRunningPropertyKey = BindableProperty.CreateReadOnly(
-			nameof(IsRunning),
+		private static readonly BindablePropertyKey IsCompletePropertyKey = BindableProperty.CreateReadOnly(
+			nameof(IsComplete),
 			typeof(bool),
 			typeof(SKConfettiEmitter),
-			true,
-			defaultBindingMode: BindingMode.OneWayToSource);
+			false);
 
-		public static readonly BindableProperty IsRunningProperty = IsRunningPropertyKey.BindableProperty;
+		public static readonly BindableProperty IsCompleteProperty = IsCompletePropertyKey.BindableProperty;
 
 		private int totalParticles = 0;
 		private double totalDuration = 0;
@@ -65,20 +64,17 @@ public double Duration
 			set => SetValue(DurationProperty, value);
 		}
 
-		/// <summary>
-		/// Gets a value indicating whether confetti is being emitted.
-		/// </summary>
-		public bool IsRunning
+		public bool IsComplete
 		{
-			get => (bool)GetValue(IsRunningProperty);
-			private set => SetValue(IsRunningPropertyKey, value);
+			get => (bool)GetValue(IsCompleteProperty);
+			private set => SetValue(IsCompletePropertyKey, value);
 		}
 
 		public event Action<int>? ParticlesCreated;
 
 		public void Update(TimeSpan deltaTime)
 		{
-			if (!IsRunning)
+			if (IsComplete)
 				return;
 
 			var prevDuration = totalDuration;
@@ -100,7 +96,10 @@ public void Update(TimeSpan deltaTime)
 
 			ParticlesCreated?.Invoke(particles);
 
-			UpdateIsRunning();
+			IsComplete =
+				Duration == 0 || // burst mode
+				(MaxParticles > 0 && totalParticles >= MaxParticles) || // reached the max particles
+				(Duration > 0 && totalDuration >= Duration); // reached the max duration
 		}
 
 		public static SKConfettiEmitter Burst(int particles) =>
@@ -114,13 +113,5 @@ public static SKConfettiEmitter Infinite(int particleRate) =>
 
 		public static SKConfettiEmitter Infinite(int particleRate, int maxParticles) =>
 			new SKConfettiEmitter(particleRate, maxParticles, -1);
-
-		private void UpdateIsRunning()
-		{
-			IsRunning =
-				Duration != 0 && // burst mode
-				(MaxParticles > 0 && totalParticles < MaxParticles) || // reached the max particles
-				(Duration > 0 && totalDuration < Duration); // reached the max duration
-		}
 	}
 }
diff --git a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiParticle.shared.cs b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiParticle.shared.cs
index 3750612a..6cc57085 100644
--- a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiParticle.shared.cs
+++ b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiParticle.shared.cs
@@ -52,11 +52,11 @@ public float Size
 
 	public SKRect Bounds { get; private set; }
 
-	public bool IsRunning { get; private set; } = true;
+	public bool IsComplete { get; private set; }
 
 	public void Draw(SKCanvas canvas)
 	{
-		if (!IsRunning || Shape == null)
+		if (IsComplete || Shape == null)
 			return;
 
 		canvas.Save();
@@ -81,7 +81,7 @@ public void Draw(SKCanvas canvas)
 
 	public void ApplyForce(SKPoint force, TimeSpan deltaTime)
 	{
-		if (!IsRunning)
+		if (IsComplete)
 			return;
 
 		var secs = (float)deltaTime.TotalSeconds;
@@ -119,11 +119,11 @@ public void ApplyForce(SKPoint force, TimeSpan deltaTime)
 				var c = Color;
 				var alpha = c.Alpha - secs;
 				Color = c.WithAlpha(alpha);
-				IsRunning = alpha > 0;
+				IsComplete = alpha <= 0;
 			}
 			else
 			{
-				IsRunning = false;
+				IsComplete = true;
 			}
 		}
 
diff --git a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiSystem.shared.cs b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiSystem.shared.cs
index 7b377619..74a3cbc9 100644
--- a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiSystem.shared.cs
+++ b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiSystem.shared.cs
@@ -97,14 +97,13 @@ public class SKConfettiSystem : BindableObject
 		typeof(SKConfettiSystem),
 		new Point(0, 9.81f));
 
-	private static readonly BindablePropertyKey IsRunningPropertyKey = BindableProperty.CreateReadOnly(
-		nameof(IsRunning),
+	private static readonly BindablePropertyKey IsCompletePropertyKey = BindableProperty.CreateReadOnly(
+		nameof(IsComplete),
 		typeof(bool),
 		typeof(SKConfettiSystem),
-		true,
-		defaultBindingMode: BindingMode.OneWayToSource);
+		false);
 
-	public static readonly BindableProperty IsRunningProperty = IsRunningPropertyKey.BindableProperty;
+	public static readonly BindableProperty IsCompleteProperty = IsCompletePropertyKey.BindableProperty;
 
 	public static readonly BindableProperty IsAnimationEnabledProperty = BindableProperty.Create(
 		nameof(IsAnimationEnabled),
@@ -222,10 +221,10 @@ public Point Gravity
 		set => SetValue(GravityProperty, value);
 	}
 
-	public bool IsRunning
+	public bool IsComplete
 	{
-		get => (bool)GetValue(IsRunningProperty);
-		private set => SetValue(IsRunningPropertyKey, value);
+		get => (bool)GetValue(IsCompleteProperty);
+		private set => SetValue(IsCompletePropertyKey, value);
 	}
 
 	internal int ParticleCount => particles.Count;
@@ -244,7 +243,7 @@ public void Update(TimeSpan deltaTime)
 
 			particle.ApplyForce(g, deltaTime);
 
-			if (!particle.IsRunning || !lastViewBounds.IntersectsWith(particle.Bounds))
+			if (particle.IsComplete || !lastViewBounds.IntersectsWith(particle.Bounds))
 			{
 				particles.RemoveAt(i);
 				removed = true;
@@ -252,7 +251,7 @@ public void Update(TimeSpan deltaTime)
 		}
 
 		if (removed)
-			UpdateIsRunning();
+			UpdateIsComplete();
 	}
 
 	public void Draw(SKCanvas canvas)
@@ -311,7 +310,7 @@ private void OnCreateParticle(int count)
 			particles.Add(particle);
 		}
 
-		UpdateIsRunning();
+		UpdateIsComplete();
 
 		Point GetNewLocation()
 		{
@@ -355,7 +354,7 @@ private static void OnEmitterChanged(BindableObject bindable, object? oldValue,
 			if (newValue is SKConfettiEmitter newE)
 				newE.ParticlesCreated += system.OnCreateParticle;
 
-			system.UpdateIsRunning();
+			system.UpdateIsComplete();
 		}
 	}
 
@@ -363,14 +362,14 @@ private static void OnIsAnimationEnabledPropertyChanged(BindableObject bindable,
 	{
 		if (bindable is SKConfettiSystem system)
 		{
-			system.UpdateIsRunning();
+			system.UpdateIsComplete();
 		}
 	}
 
-	private bool UpdateIsRunning() =>
-		IsRunning =
-			particles.Count != 0 &&
-			Emitter?.IsRunning == true &&
+	private bool UpdateIsComplete() =>
+		IsComplete =
+			particles.Count == 0 &&
+			Emitter?.IsComplete != false &&
 			IsAnimationEnabled;
 
 	private static SKConfettiColorCollection CreateDefaultColors() =>
diff --git a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiView.shared.cs b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiView.shared.cs
index 013f93a0..32554302 100644
--- a/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiView.shared.cs
+++ b/source/SkiaSharp.Extended.UI/Controls/Confetti/SKConfettiView.shared.cs
@@ -4,14 +4,13 @@ namespace SkiaSharp.Extended.UI.Controls;
 
 public class SKConfettiView : SKAnimatedSurfaceView
 {
-	private static readonly BindablePropertyKey IsRunningPropertyKey = BindableProperty.CreateReadOnly(
-		nameof(IsRunning),
+	private static readonly BindablePropertyKey IsCompletePropertyKey = BindableProperty.CreateReadOnly(
+		nameof(IsComplete),
 		typeof(bool),
 		typeof(SKConfettiView),
-		false,
-		defaultBindingMode: BindingMode.OneWayToSource);
+		false);
 
-	public static readonly BindableProperty IsRunningProperty = IsRunningPropertyKey.BindableProperty;
+	public static readonly BindableProperty IsCompleteProperty = IsCompletePropertyKey.BindableProperty;
 
 	public static readonly BindableProperty SystemsProperty = BindableProperty.Create(
 		nameof(Systems),
@@ -37,17 +36,10 @@ public SKConfettiView()
 		OnSystemsPropertyChanged(this, null, Systems);
 	}
 
-	/// <summary>
-	/// Gets a value indicating whether the confetti emission is running.
-	/// </summary>
-	/// <remarks>
-	/// NOTE this is a <see cref="BindingMode.OneWayToSource"/> property, if you wish to control whether the animation is
-	/// enabled refer to the <see cref="SKAnimatedSurfaceView.IsAnimationEnabled"/> property.
-	/// </remarks>
-	public bool IsRunning
+	public bool IsComplete
 	{
-		get => (bool)GetValue(IsRunningProperty);
-		private set => SetValue(IsRunningPropertyKey, value);
+		get => (bool)GetValue(IsCompleteProperty);
+		private set => SetValue(IsCompletePropertyKey, value);
 	}
 
 	public SKConfettiSystemCollection? Systems
@@ -66,7 +58,7 @@ protected override void Update(TimeSpan deltaTime)
 			var system = Systems[i];
 			system.Update(deltaTime);
 
-			if (!system.IsRunning)
+			if (system.IsComplete)
 				Systems.RemoveAt(i);
 		}
 	}
@@ -114,7 +106,7 @@ private void OnSystemsCollectionChanged(object? sender, NotifyCollectionChangedE
 			Invalidate();
 		}
 
-		UpdateIsRunning();
+		UpdateIsComplete();
 	}
 
 	private void OnIsAnimationEnabledPropertyChanged()
@@ -139,28 +131,28 @@ private static void OnSystemsPropertyChanged(BindableObject bindable, object? ol
 		if (newValue is SKConfettiSystemCollection newCollection)
 			newCollection.CollectionChanged += cv.OnSystemsCollectionChanged;
 
-		cv.UpdateIsRunning();
+		cv.UpdateIsComplete();
 	}
 
-	private void UpdateIsRunning()
+	private void UpdateIsComplete()
 	{
 		if (Systems is null || Systems.Count == 0)
 		{
-			IsRunning = false;
+			IsComplete = true;
 			return;
 		}
 
-		var isRunning = true;
+		var isComplete = false;
 		foreach (var system in Systems)
 		{
-			if (!system.IsRunning)
+			if (system.IsComplete)
 			{
-				isRunning = false;
+				isComplete = true;
 				break;
 			}
 		}
 
-		IsRunning = isRunning;
+		IsComplete = isComplete;
 	}
 
 	private static SKConfettiSystemCollection CreateDefaultSystems() =>
diff --git a/source/SkiaSharp.Extended.UI/Controls/Lottie/SKLottieView.shared.cs b/source/SkiaSharp.Extended.UI/Controls/Lottie/SKLottieView.shared.cs
index 8aa20a03..b4d1d072 100644
--- a/source/SkiaSharp.Extended.UI/Controls/Lottie/SKLottieView.shared.cs
+++ b/source/SkiaSharp.Extended.UI/Controls/Lottie/SKLottieView.shared.cs
@@ -26,14 +26,13 @@ public class SKLottieView : SKAnimatedSurfaceView
 		BindingMode.TwoWay,
 		propertyChanged: OnProgressDurationPropertyChanged);
 
-	private static readonly BindablePropertyKey IsRunningPropertyKey = BindableProperty.CreateReadOnly(
-		nameof(IsRunning),
+	private static readonly BindablePropertyKey IsCompletePropertyKey = BindableProperty.CreateReadOnly(
+		nameof(IsComplete),
 		typeof(bool),
 		typeof(SKLottieView),
-		false,
-		defaultBindingMode: BindingMode.OneWayToSource);
+		false);
 
-	public static readonly BindableProperty IsRunningProperty = IsRunningPropertyKey.BindableProperty;
+	public static readonly BindableProperty IsCompleteProperty = IsCompletePropertyKey.BindableProperty;
 
 	public static readonly BindableProperty RepeatCountProperty = BindableProperty.Create(
 		nameof(RepeatCount),
@@ -76,10 +75,10 @@ public TimeSpan Progress
 		set => SetValue(ProgressProperty, value);
 	}
 
-	public bool IsRunning
+	public bool IsComplete
 	{
-		get => (bool)GetValue(IsRunningProperty);
-		private set => SetValue(IsRunningPropertyKey, value);
+		get => (bool)GetValue(IsCompleteProperty);
+		private set => SetValue(IsCompletePropertyKey, value);
 	}
 
 	public int RepeatCount
@@ -135,7 +134,7 @@ private void UpdateProgress(TimeSpan progress)
 	{
 		if (animation is null)
 		{
-			IsRunning = false;
+			IsComplete = true;
 			return;
 		}
 
@@ -159,7 +158,7 @@ private void UpdateProgress(TimeSpan progress)
 			// we need to reverse to finish the run
 			playForwards = !playForwards;
 
-			IsRunning = true;
+			IsComplete = false;
 		}
 		else
 		{
@@ -187,9 +186,9 @@ private void UpdateProgress(TimeSpan progress)
 					playForwards = !playForwards;
 			}
 
-			IsRunning =
-				!isFinishedRun &&
-				repeatsCompleted < totalRepeatCount;
+			IsComplete =
+				isFinishedRun &&
+				repeatsCompleted >= totalRepeatCount;
 		}
 
 		if (!IsAnimationEnabled)
diff --git a/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiEmitterTest.cs b/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiEmitterTest.cs
index f7fdb264..5db27f16 100644
--- a/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiEmitterTest.cs
+++ b/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiEmitterTest.cs
@@ -28,13 +28,13 @@ public void ParticleRateNoMaxBurstRunsOnce(int milliseconds)
 
 			Assert.Equal(100, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.False(emitter.IsRunning);
+			Assert.True(emitter.IsComplete);
 
 			emitter.Update(dt);
 
 			Assert.Equal(100, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.False(emitter.IsRunning);
+			Assert.True(emitter.IsComplete);
 		}
 
 		[Theory]
@@ -60,13 +60,13 @@ public void ParticleRateWithMaxBurstRunsOnce(int milliseconds)
 
 			Assert.Equal(50, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.False(emitter.IsRunning);
+			Assert.True(emitter.IsComplete);
 
 			emitter.Update(dt);
 
 			Assert.Equal(50, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.False(emitter.IsRunning);
+			Assert.True(emitter.IsComplete);
 		}
 
 		[Theory]
@@ -92,22 +92,22 @@ public void ParticleRateLargerMaxBurstRunsOnce(int milliseconds)
 
 			Assert.Equal(100, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.False(emitter.IsRunning);
+			Assert.True(emitter.IsComplete);
 
 			emitter.Update(dt);
 
 			Assert.Equal(100, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.False(emitter.IsRunning);
+			Assert.True(emitter.IsComplete);
 		}
 
 		[Theory]
-		[InlineData(0, 0, 0, true, true)]
-		[InlineData(10, 1, 2, true, true)]
-		[InlineData(500, 50, 100, true, false)]
-		[InlineData(1000, 100, 100, false, false)]
-		[InlineData(10000, 100, 100, false, false)]
-		public void ParticleRateNoMaxOneMin(int milliseconds, int expectedCreated, int expectedCreated2, bool isRunning, bool isRunning2)
+		[InlineData(0, 0, 0, false, false)]
+		[InlineData(10, 1, 2, false, false)]
+		[InlineData(500, 50, 100, false, true)]
+		[InlineData(1000, 100, 100, true, true)]
+		[InlineData(10000, 100, 100, true, true)]
+		public void ParticleRateNoMaxOneMin(int milliseconds, int expectedCreated, int expectedCreated2, bool complete, bool complete2)
 		{
 			var dt = TimeSpan.FromMilliseconds(milliseconds);
 
@@ -125,16 +125,16 @@ public void ParticleRateNoMaxOneMin(int milliseconds, int expectedCreated, int e
 
 			Assert.Equal(expectedCreated, totalCreated);
 			Assert.Equal(1, totalInvoke);
-			Assert.Equal(isRunning, emitter.IsRunning);
+			Assert.Equal(complete, emitter.IsComplete);
 
 			emitter.Update(dt);
 
 			Assert.Equal(expectedCreated2, totalCreated);
-			if (!isRunning)
+			if (complete)
 				Assert.Equal(1, totalInvoke);
 			else
 				Assert.Equal(2, totalInvoke);
-			Assert.Equal(isRunning2, emitter.IsRunning);
+			Assert.Equal(complete2, emitter.IsComplete);
 		}
 	}
 }
diff --git a/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiSystemTest.cs b/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiSystemTest.cs
index 109a11dd..657fb876 100644
--- a/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiSystemTest.cs
+++ b/tests/SkiaSharp.Extended.UI.Tests/Controls/Confetti/SKConfettiSystemTest.cs
@@ -1,26 +1,27 @@
-using Xunit;
+using System;
+using Xunit;
 
 namespace SkiaSharp.Extended.UI.Controls.Tests
 {
 	public class SKConfettiSystemTest
 	{
 		[Fact]
-		public void DefaultIsNotRunning()
+		public void DefaultIsNotComplete()
 		{
 			var system = new SKConfettiSystem();
 
 			Assert.True(system.IsAnimationEnabled);
-			Assert.False(system.IsRunning);
+			Assert.False(system.IsComplete);
 		}
 
 		[Fact]
-		public void NotRunningIsReallyNotRunning()
+		public void NotRunningIsNotComplete()
 		{
 			var system = new SKConfettiSystem();
 			system.IsAnimationEnabled = false;
 
 			Assert.False(system.IsAnimationEnabled);
-			Assert.False(system.IsRunning);
+			Assert.False(system.IsComplete);
 		}
 	}
 }