Fix #787: encapsulate local ctx on task execution #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 90.42% 90.43% +<.01%
==========================================
Files 426 426
Lines 12308 12302 -6
Branches 2264 2258 -6
==========================================
- Hits 11130 11125 -5
+ Misses 1178 1177 -1 |
|
I like it. |
|
Some tests would help, if you have the time. |
alexandru
pushed a commit
that referenced
this pull request
Jan 12, 2019
* Acquire lock per subscription instead of observable-wide lock * Update cats-effect, cats-effect-laws to 1.1.0 (#788) * Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26 (#785) * Scala 2.12.8 (#797) * Update intervalWithFixedDelay scaladoc (#798) * Update intervalWithFixedDelay scaladoc * Update Observable.scala * fix scalacOptions (#796) * fix scalacOptions "-Ywarn-unused-import" removed since Scala 2.13.x scala/scala@ad25805 * fix scalacOptions for Scala 2.13.x some options removed since Scala 2.13.x * Eagerly null out dequeued elements in ChunkedArrayQueue (#803) * Observable buffers refactoring (#801) * Refactoring of Observable buffers and OverflowStrategy * Observable.create change signature * Fix Mima reports * Small adjustments * Add forgotten default value for maxBatch * Make OverflowStrategy.Unbounded final * Fix Mima * Fix #787: encapsulate local ctx on task execution (#802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically redid what was in one of my previous PRs. This ensures Local context is left unchanged when an unsafe method starts executing.
Not entirely sure this fixes all the possible issues (I'm suspicious about
.start), but I think it's better than what we currently have.