Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute an Action (() => Unit) #200

Merged
merged 3 commits into from
Aug 10, 2016
Merged

Execute an Action (() => Unit) #200

merged 3 commits into from
Aug 10, 2016

Conversation

aoprisan
Copy link
Contributor

@aoprisan aoprisan commented Aug 2, 2016

Added an execute overload which takes an Action (() => Unit), wraps it in RunnableAction and forwards it to the default execute method.

@alexandru alexandru changed the title execute an Action (() => Unit) Execute an Action (() => Unit) Aug 10, 2016
@codecov-io
Copy link

codecov-io commented Aug 10, 2016 •
edited
Loading

Current coverage is 83.74% (diff: 0.00%)

No coverage report found for master at 12597dd.

Powered by Codecov. Last update 12597dd...10460c1

@alexandru
Copy link
Member

  • changed name, because this particular override is problematic as it can conflict with the main method, because of that by-name parameter - in all other cases the arity of the methods are different and so you can't end up with a conflict - this is related to by-name params, I would have been fine with a Function1, but then that wouldn't have been consistent
  • added a simple test

@alexandru alexandru merged commit 56baaee into master Aug 10, 2016
@alexandru alexandru deleted the schedulerExecuteAction branch November 8, 2016 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexandru alexandru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aoprisan @codecov-io @alexandru