Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes cluster tests #2195

Merged
merged 3 commits into from
Apr 23, 2024
Merged

chore: Fixes cluster tests #2195

merged 3 commits into from
Apr 23, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Apr 23, 2024

Description

Fixes cluster tests

  • Uses common pattern for migration tests
  • Removes heavy tests TestAccCluster_AzureUpdateToNVME and TestAccCluster_basicAWS_instanceScale that only checks provider_instance_size_name attribute change

Link to any related issue(s): CLOUDP-245163

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli requested a review from a team as a code owner April 23, 2024 15:44
@@ -654,12 +590,11 @@ func TestAccClusterRSCluster_ProviderRegionName(t *testing.T) {
})
}

func TestAccClusterRSCluster_Global(t *testing.T) {
func TestAccCluster_Global(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosuma this is the test using multi-region cluster with execution project

Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@lantoli lantoli merged commit 9600063 into master Apr 23, 2024
31 checks passed
@lantoli lantoli deleted the CLOUDP-245163_cluster_tests branch April 23, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants