Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax are not mandatory and creates confusion #58

Closed
nikhil-mongo opened this issue Nov 1, 2019 · 1 comment · Fixed by #63
Closed

Syntax are not mandatory and creates confusion #58

nikhil-mongo opened this issue Nov 1, 2019 · 1 comment · Fixed by #63
Labels
non-blocking bug Small fixes to doc or code that don't impede use.

Comments

@nikhil-mongo
Copy link
Collaborator

To launch a cluster using terraform,
mongo_db_major_version = “4.0” // this is in documentation and requires the version to be in string, but with version 4.2
mongo_db_major_version = 4.2 // this will work without the “”.

Please see if any changes need to be made to make this mandatory.

@themantissa themantissa added the non-blocking bug Small fixes to doc or code that don't impede use. label Nov 4, 2019
@PacoDw
Copy link
Contributor

PacoDw commented Nov 7, 2019

Hello @nikhil-mongo,
Thanks for your review, I made a few changes to allow string and float types to be able to set to the mongo_db_major_version attr, you can check the changes on the pr #63.

If you have another comment plz let us know.

@PacoDw PacoDw closed this as completed in #63 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-blocking bug Small fixes to doc or code that don't impede use.
Projects
None yet
3 participants