Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5274): deprecate write concern options #3752

Merged
merged 17 commits into from
Jul 6, 2023
Merged

feat(NODE-5274): deprecate write concern options #3752

merged 17 commits into from
Jul 6, 2023

Conversation

durran
Copy link
Member

@durran durran commented Jul 3, 2023 •
edited
Loading

Description

Deprecates old write concern options.

What is changing?

  • Deprecates wtimeout, j, and fsync options.
  • Adds new WriteConcern.apply() method to add a write concern to a command.
  • Updates instances of adding write concern to commands to use the new apply method.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5274

Release Highlight

Write Concern legacy options deprecated

wtimeout, j, and fsync options have been deprecated, please use wtimeoutMS and journal instead.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

nbbeeken
nbbeeken reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to get you some comments for tmo even though this is draft

src/write_concern.ts Outdated Show resolved Hide resolved
src/write_concern.ts Show resolved Hide resolved
src/write_concern.ts Outdated Show resolved Hide resolved
src/write_concern.ts Outdated Show resolved Hide resolved
test/unit/write_concern.test.ts Show resolved Hide resolved
@durran durran marked this pull request as ready for review July 5, 2023 14:21
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 5, 2023
nbbeeken
nbbeeken requested changes Jul 5, 2023
View reviewed changes
test/unit/write_concern.test.ts Outdated Show resolved Hide resolved
src/sessions.ts Show resolved Hide resolved
src/sessions.ts Show resolved Hide resolved
src/gridfs/upload.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 5, 2023
@nbbeeken nbbeeken merged commit 1f880ea into main Jul 6, 2023
@nbbeeken nbbeeken deleted the NODE-5274 branch July 6, 2023 17:37
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
Merged
This was referenced Aug 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @nbbeeken @W-A-James