Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-1797): Error when ChangeStream used as iterator and emitter concurrently #2871

Merged
merged 12 commits into from
Jul 9, 2021
Merged

fix(NODE-1797): Error when ChangeStream used as iterator and emitter concurrently #2871

merged 12 commits into from
Jul 9, 2021

Commits on Jun 28, 2021

  1. test: Add test to check that change streams can be used as iterators … 

    …or emitters, but not both concurrently
    @W-A-James
    W-A-James committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    a459704 View commit details
    Browse the repository at this point in the history

  2. fix: (wip) start fix to ensure change streams can be used as iterator… 

    …s or emitters, but not both at once
    @W-A-James
    W-A-James committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    c167318 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. fix: (wip) Fixing tests

    @W-A-James
    W-A-James committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    1e8e112 View commit details
    Browse the repository at this point in the history

  2. test: Fix tests for 'on' and 'hasNext'

    @W-A-James
    W-A-James committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    ed6cb45 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. fix: Throw error MongoDriverError only when attempting to watch changes

    @W-A-James
    W-A-James committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    f3d2af0 View commit details
    Browse the repository at this point in the history

  2. test: Clean up test code

    @W-A-James
    W-A-James committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    2bf784a View commit details
    Browse the repository at this point in the history

  3. test: Ensure that callbacks execute before test cleanup

    @W-A-James
    W-A-James committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    a585b4b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. refactor: remove errorIfIsX functions and use Symbol for mode property

    @W-A-James
    W-A-James committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    b929dd5 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. refactor: change _setIsEmitter and _setIsIterator methods to helper f… 

    …unctions
    @W-A-James
    W-A-James committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    0d9d213 View commit details
    Browse the repository at this point in the history

  2. fix: Initialize changeStream mode to false in constructor

    @W-A-James
    W-A-James committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    5d02507 View commit details
    Browse the repository at this point in the history

  3. test: clean up tests

    @W-A-James
    W-A-James committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    df93e3c View commit details
    Browse the repository at this point in the history

  4. test: Remove unneeded tests

    @W-A-James
    W-A-James committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    ce2cbe7 View commit details
    Browse the repository at this point in the history