Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6602): only wrap errors from SOCKS in network errors #4347

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 4, 2024

Description

What is changing?

  • SOCKS errors should be wrapped in our network error type
  • Improve error messages for socket errors
Is there new documentation needed for these changes?

No

What is the motivation for this change?

While fixing NODE-6552 the error message changes helped with debugging and caught the error convert bug in a driveby

Release Highlight

SOCKS5: MongoNetworkError wrap fix

If the driver encounters an error while connecting to a socks5 proxy, the driver wraps the socks5 error in a MongoNetworkError. In some circumstances, this resulted in the driver wrapping MongoNetworkErrors inside MongoNetworkErrors.

The driver no longer double wraps errors in MongoNetworkErrors.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Base automatically changed from NODE-6552-fix-perf-tests to main December 5, 2024 00:25
@nbbeeken nbbeeken marked this pull request as ready for review December 5, 2024 15:38
@baileympearson baileympearson self-assigned this Dec 5, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 5, 2024
@baileympearson baileympearson merged commit ed83f36 into main Dec 6, 2024
31 checks passed
@baileympearson baileympearson deleted the NODE-6602 branch December 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants