Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-6593): add support for [email protected] #4346

Merged
merged 4 commits into from
Dec 6, 2024
Merged

feat(NODE-6593): add support for [email protected] #4346

merged 4 commits into from
Dec 6, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Dec 3, 2024 •
edited by nbbeeken
Loading

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

[email protected] is now supported for zstd compression

The new @mongodb-js/[email protected] release can now be used with the driver for zstd compression.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title chore(NODE-6593): test against [email protected] feat(NODE-6593): add support for [email protected] Dec 6, 2024
@baileympearson baileympearson marked this pull request as ready for review December 6, 2024 19:39
nbbeeken
nbbeeken approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs release notes, which can just link to the zstd release I think

@nbbeeken nbbeeken added the Team Review Needs review from team label Dec 6, 2024
@nbbeeken nbbeeken self-assigned this Dec 6, 2024
@nbbeeken nbbeeken requested a review from W-A-James December 6, 2024 20:04
@nbbeeken nbbeeken merged commit ea8a33f into main Dec 6, 2024
27 of 29 checks passed
@nbbeeken nbbeeken deleted the NODE-6593 branch December 6, 2024 20:51
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @nbbeeken @W-A-James