-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6337): implement client bulk write batching #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-6337-bulk-write-batch
branch
from
September 25, 2024 15:10
35e62b7
to
b8fcf14
Compare
5 tasks
durran
force-pushed
the
NODE-6337-bulk-write-batch
branch
3 times, most recently
from
September 25, 2024 23:20
0c4de74
to
9f63397
Compare
baileympearson
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Sep 26, 2024
baileympearson
requested changes
Sep 26, 2024
durran
force-pushed
the
NODE-6337-bulk-write-batch
branch
from
September 30, 2024 20:57
d4d4bc6
to
1951d97
Compare
durran
force-pushed
the
NODE-6337-bulk-write-batch
branch
from
September 30, 2024 21:06
1951d97
to
0ed7ce8
Compare
baileympearson
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes!
baileympearson
approved these changes
Oct 1, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements batching of client bulk writes.
What is changing?
DocumentSequence
to be able to serialize itself and return its documents byte length when pushing to it.maxMessageSizeBytes
andmaxWriteBatchSize
up to the topology level.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6337
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript