-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6289): allow valid srv hostnames with less than 3 parts #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aditi-khare-mongoDB
changed the title
feat(NODE-6289): DRIVERS-2922 Downstream Changes PoC
feat(NODE-6289): DRIVERS 2922 Downstream Changes PoC
Aug 15, 2024
aditi-khare-mongoDB
changed the title
feat(NODE-6289): DRIVERS 2922 Downstream Changes PoC
feat(NODE-6289): Allow valid SRV hostnames with less than 3 parts
Sep 5, 2024
aditi-khare-mongoDB
force-pushed
the
uri-validate-less
branch
from
September 5, 2024 05:02
bda0451
to
586f7c0
Compare
aditi-khare-mongoDB
changed the title
feat(NODE-6289): Allow valid SRV hostnames with less than 3 parts
feat(NODE-6289): allow valid srv hostnames with less than 3 parts
Sep 5, 2024
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Sep 19, 2024
W-A-James
requested changes
Sep 19, 2024
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
W-A-James
requested changes
Sep 20, 2024
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
W-A-James
requested changes
Sep 26, 2024
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
aditi-khare-mongoDB
force-pushed
the
uri-validate-less
branch
from
October 8, 2024 20:45
cdc2501
to
79f41e4
Compare
aditi-khare-mongoDB
force-pushed
the
uri-validate-less
branch
from
October 8, 2024 20:45
d17f346
to
eafaf61
Compare
W-A-James
approved these changes
Oct 14, 2024
Failing tests are unrelated known flaky tests |
W-A-James
requested changes
Oct 14, 2024
LGTM with respect to my comments |
W-A-James
approved these changes
Oct 15, 2024
W-A-James
approved these changes
Oct 15, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downstream changes for DRIVERS-2922 (PR).
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Do not throw an error on valid URI formats pre-DNS resolution, and require stricter domain matching post-DNS resolution.
Release Highlight
Allow SRV hostnames with less than three
.
separated partsIn an effort to make internal networking solutions easier to use like deployments using kubernetes, the client now accepts SRV hostname strings with one or two
.
separated parts.For security reasons, the returned addresses of SRV strings with less than three parts must end with the entire SRV hostname and contain at least one additional domain level. This is because this added validation ensures that the returned address(es) are from a known host. In future releases, we plan on extending this validation to SRV strings with three or more parts, as well.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript