Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6171): RTT set to zero when serverMonitoringMode=stream #4110

Merged
merged 12 commits into from
May 15, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented May 14, 2024

Description

What is changing?

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-6171

Release Highlight

Server Selection performance regression due to incorrect RTT measurement

Starting in version 6.6.0, when using the stream server monitoring mode, heartbeats were incorrectly timed as having a duration of 0, leading to server selection viewing each server as equally desirable for selection.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review May 15, 2024 16:12
@nbbeeken nbbeeken self-assigned this May 15, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 15, 2024
@nbbeeken nbbeeken self-requested a review May 15, 2024 16:18
@W-A-James W-A-James requested a review from nbbeeken May 15, 2024 17:38
@W-A-James W-A-James changed the title fix(NODE-6171): Ensure that rtt is correctly measured fix(NODE-6171): Fix rtt being set to zero when serverMonitoringMode=stream May 15, 2024
@nbbeeken nbbeeken changed the title fix(NODE-6171): Fix rtt being set to zero when serverMonitoringMode=stream fix(NODE-6171): RTT set to zero when serverMonitoringMode=stream May 15, 2024
@nbbeeken nbbeeken merged commit 7a7ec5b into main May 15, 2024
21 of 26 checks passed
@nbbeeken nbbeeken deleted the NODE-6171/fix-0-rtt-bug branch May 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants