Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-3881): require hello command + OP_MSG when 'loadBalanced=True' #3907

Merged
merged 17 commits into from
Nov 6, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Nov 1, 2023

Description

Send the hello command + OP_MSG when loadBalanced is true according to spec.

What is changing?

  • When loadBalanced is true, we send the hello command over the legacy hello command.
  • When loadBalanced is true we send OP_MSG over OP_QUERY.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-3881

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review November 2, 2023 11:19
@W-A-James W-A-James self-assigned this Nov 2, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 2, 2023
test/unit/cmap/connection.test.ts Outdated Show resolved Hide resolved
src/cmap/connection.ts Outdated Show resolved Hide resolved
test/unit/cmap/connect.test.ts Show resolved Hide resolved
test/unit/cmap/connect.test.ts Show resolved Hide resolved
test/unit/cmap/connect.test.ts Outdated Show resolved Hide resolved
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 3, 2023
durran
durran previously approved these changes Nov 3, 2023
src/cmap/connect.ts Show resolved Hide resolved
@W-A-James W-A-James merged commit fd58eec into main Nov 6, 2023
25 checks passed
@W-A-James W-A-James deleted the NODE-3881-hello-plus-op_msg branch November 6, 2023 19:03
@alenakhineika alenakhineika removed the Team Review Needs review from team label Nov 8, 2023
aditi-khare-mongoDB pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants