-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5197): add server monitoring mode #3899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-5197-server-monitoring-mode
branch
9 times, most recently
from
October 20, 2023 13:09
1c716c0
to
5b730ca
Compare
durran
force-pushed
the
NODE-5197-server-monitoring-mode
branch
3 times, most recently
from
November 6, 2023 19:10
d53c18d
to
7a79b6c
Compare
durran
force-pushed
the
NODE-5197-server-monitoring-mode
branch
from
November 6, 2023 19:29
7a79b6c
to
94b4957
Compare
durran
force-pushed
the
NODE-5197-server-monitoring-mode
branch
from
November 6, 2023 20:16
94b4957
to
b8b5173
Compare
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Nov 8, 2023
W-A-James
reviewed
Nov 8, 2023
W-A-James
previously approved these changes
Nov 9, 2023
W-A-James
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Nov 9, 2023
nbbeeken
requested changes
Nov 13, 2023
nbbeeken
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new
serverMonitoringMode
flag to tell monitors to stream, poll, or auto-detect.What is changing?
serverMonitoringMode
(stream|poll|auto) to URI options and MongoClientOptionsIs there new documentation needed for these changes?
Yes, we must document the new option.
What is the motivation for this change?
NODE-5197
Release Highlight
New client option
serverMonitoringMode
added.For users that want to control the behaviour of the monitoring connection between each node in the topology, a new option,
serverMonitoringMode
, has been added. This defaults toauto
but can be forced into a specific mode by providing a value ofpoll
orstream
. A polling monitor periodically issues ahello
command to the node at an interval ofheartbeatFrequencyMS
. A streaming monitor sends an initialhello
and then will automatically get a response from the Node when a change in server configuration occurs or at a maximum time ofheartbeatFrequencyMS
. The value of that option defaults to 10000 milliseconds.This new option can be provided in the connection string or as an option to the
MongoClient
.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript