Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5262, NODE-5311): batch backport #3683

Merged
merged 3 commits into from
May 26, 2023
Merged

fix(NODE-5262, NODE-5311): batch backport #3683

merged 3 commits into from
May 26, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 24, 2023 •
edited
Loading

Description

What is changing?

Backports #3663 and #3682.

Also updates CI scripts to pull in [email protected].

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title fix(no-story): batch fix backport fix(no-story): batch backport May 24, 2023
@baileympearson baileympearson changed the title fix(no-story): batch backport fix(NODE-5262, NODE-5311): batch backport May 24, 2023
baileympearson added a commit to baileympearson/node-mongodb-native that referenced this pull request May 25, 2023
@baileympearson
test(no-story): bump mongodb-client-encryption pinned commits to 2.8.…
7d3621f 
…0 release (mongodb#3683)
baileympearson pushed a commit to baileympearson/node-mongodb-native that referenced this pull request May 25, 2023
@nbbeeken @baileympearson
fix(NODE-5262): AWS Lambda metadata detection logic is too permissive (…
9f29755 
…mongodb#3683)
baileympearson added a commit to baileympearson/node-mongodb-native that referenced this pull request May 25, 2023
@baileympearson
fix(NODE-5311): construct error messages for AggregateErrors in Node1…
6e3a374 
…6+ (mongodb#3683)
baileympearson added a commit that referenced this pull request May 25, 2023
@baileympearson
test(no-story): bump mongodb-client-encryption pinned commits to 2.8.…
66ba28f 
…0 release (#3683)
baileympearson pushed a commit that referenced this pull request May 25, 2023
@nbbeeken @baileympearson
fix(NODE-5262): AWS Lambda metadata detection logic is too permissive (…
0becdac 
…#3683)
baileympearson added a commit that referenced this pull request May 25, 2023
@baileympearson
fix(NODE-5311): construct error messages for AggregateErrors in Node1…
acaf1a0 
…6+ (#3683)
baileympearson added a commit that referenced this pull request May 25, 2023
@baileympearson
fix(NODE-5311): construct error messages for AggregateErrors in Node1…
ba20eca 
…6+ (#3683)
@baileympearson baileympearson marked this pull request as ready for review May 25, 2023 20:05
@durran durran self-assigned this May 26, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 26, 2023
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 26, 2023
dariakp
dariakp reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that merge commit going to show up on 4.x if you do the rebase/fast-forward?

@durran durran merged commit 98b7bdf into 4.x May 26, 2023
@durran durran deleted the no-story-misc-backports branch May 26, 2023 14:49
durran pushed a commit that referenced this pull request May 26, 2023
@baileympearson @durran
test(no-story): bump mongodb-client-encryption pinned commits to 2.8.…
1c36949 
…0 release (#3683)
durran pushed a commit that referenced this pull request May 26, 2023
@nbbeeken @durran
fix(NODE-5262): AWS Lambda metadata detection logic is too permissive (…
c0c3d99 
…#3683)
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp left review comments

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baileympearson @durran @dariakp @nbbeeken