-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-4533): session support error message and unified test runner #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
commented
Aug 12, 2022
dariakp
force-pushed
the
NODE-4533/fixups-for-unified-runner
branch
from
August 12, 2022 15:34
93060c5
to
648212c
Compare
baileympearson
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Aug 15, 2022
baileympearson
requested changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for visibility but only two minor comments.
dariakp
force-pushed
the
NODE-4533/fixups-for-unified-runner
branch
from
August 16, 2022 16:43
163c00c
to
a88b730
Compare
baileympearson
previously approved these changes
Aug 16, 2022
baileympearson
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Aug 16, 2022
nbbeeken
previously approved these changes
Aug 16, 2022
nbbeeken
approved these changes
Aug 16, 2022
baileympearson
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-4533 for NODE-4325
What is changing?
isError
orisClientError
)MongoCryptError
- these aren't standardized in the fle module, so it's a bit awkward, see comment for further discussionIs there new documentation needed for these changes?
No
What is the motivation for this change?
Splitting up groundwork from the sdam-specific unified changes
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>