Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4533): session support error message and unified test runner #3355

Merged
merged 8 commits into from
Aug 16, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Aug 12, 2022

Description

NODE-4533 for NODE-4325

What is changing?

  • Fixed error checking in the unified runner and the discovered non-spec compliant error message for snapshot sessions (we were skipping error checks entirely whenever an expectation contained isError or isClientError)
    • There is a new check for MongoCryptError - these aren't standardized in the fle module, so it's a bit awkward, see comment for further discussion
  • Fixed a bunch of TS issues in the runner, tried to standardize the null handling as much as possible
  • Updated event capturing logic since we'll be adding a new event type in the subsequent work
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Splitting up groundwork from the sdam-specific unified changes

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp force-pushed the NODE-4533/fixups-for-unified-runner branch from 93060c5 to 648212c Compare August 12, 2022 15:34
@dariakp dariakp marked this pull request as ready for review August 12, 2022 16:02
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 15, 2022
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for visibility but only two minor comments.

test/tools/unified-spec-runner/runner.ts Show resolved Hide resolved
test/tools/unified-spec-runner/operations.ts Outdated Show resolved Hide resolved
@dariakp dariakp force-pushed the NODE-4533/fixups-for-unified-runner branch from 163c00c to a88b730 Compare August 16, 2022 16:43
baileympearson
baileympearson previously approved these changes Aug 16, 2022
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 16, 2022
nbbeeken
nbbeeken previously approved these changes Aug 16, 2022
test/tools/unified-spec-runner/entities.ts Outdated Show resolved Hide resolved
@dariakp dariakp dismissed stale reviews from nbbeeken and baileympearson via e4b30af August 16, 2022 19:11
@dariakp dariakp merged commit 6a0e502 into main Aug 16, 2022
@dariakp dariakp deleted the NODE-4533/fixups-for-unified-runner branch August 16, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants