Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3621): fixed type of documentKey property on ChangeStreamDocument #3118

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

rvanmil
Copy link
Contributor

@rvanmil rvanmil commented Jan 27, 2022

Description

This fixes the bug described in Jira issue NODE-3621. The documentKey property on the ChangeStreamDocument type is currently typed incorrectly.

I have also checked the MongoDB Realm JS code and it appears the type is implemented correctly in that codebase.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp added the External Submission PR submitted from outside the team label Jan 31, 2022
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apologies for the delay, thanks for catching this!

@nbbeeken nbbeeken changed the title fix(NODE-3621): fixed the documentKey property on ChangeStreamDocumen… fix(NODE-3621): fixed type of documentKey property on ChangeStreamDocument Feb 1, 2022
@nbbeeken nbbeeken merged commit c63a21b into mongodb:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants