Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3416): make change stream generic default to Document #2882

Merged
merged 2 commits into from
Jul 7, 2021
Merged

fix(NODE-3416): make change stream generic default to Document #2882

merged 2 commits into from
Jul 7, 2021

Conversation

vkarpov15
Copy link
Contributor

Description

In most places, the node driver defaults to using Document if no generic param is provided. ChangeStream looks to be an exception.

What changed?

Added a default generic param to ChangeStream

Are there any files to ignore?

Nope

@nbbeeken nbbeeken changed the title fix(change_stream): make change stream generic default to Document fix(NODE-3416): make change stream generic default to Document Jul 7, 2021
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken requested a review from dariakp July 7, 2021 15:59
@nbbeeken nbbeeken merged commit 3d490dc into mongodb:4.0 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants