fix(NODE-3174): Preserve sort key order for numeric string keys #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
force-pushed
the
NODE-3174/preserve-sort-key-order
branch
from
79c4b10
to
ed9ee63
Compare
durran
approved these changes
Apr 27, 2021
It really depends on how the investigation for the unified test framework/extended json in our internal DRIVERS-1701 ticket plays out. Unless the outcome is favorable, this won't be able to be addressed at all, but I wanted to keep the test marked regardless so that it's top of mind whenever we get around to cleaning them up. |
emadum
suggested changes
Apr 27, 2021
There was a problem hiding this comment.
Nice work! Can you create a Jira ticket for the future work described in the TODO comments, and update the comments with a reference to the ticket? These kind of comments have a tendency to never get followed up on if they aren't associated with a ticket. (Edit: perhaps the DRIVERS ticket mentioned above would suffice?)
emadum
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated internal representation of sort to use a map instead of a plain object in order to preserve correct ordering for multi-key sort queries; also enabled the use of a map type to specify input sort options