PORT: NODE-3122: Adds close event to GridFS stream. #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
reviewed
Mar 19, 2021
There was a problem hiding this comment.
The GridFS changes LGTM! 👍
However the changes made directly to the config.yml to add fermium will be lost the next time the generate_evergreen_tasks.js script is run. Not sure if you'd prefer to fix that in this PR, or if we should just address it when we get to NODE-3106?
|
Oh I didn't realise it was generated. I'll remove that and pick up that ticket. |
durran
force-pushed
the
NODE-3122/gridfs-upload-stream-close-40
branch
from
c1ce468
to
e6b5e60
Compare
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.