Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] fix: move session support check to operation layer #2750

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

nbbeeken
Copy link
Contributor

Session support check is now performed after server selection
this ensures the monitor was able to update the topology description

NODE-3100

@nbbeeken nbbeeken force-pushed the NODE-3100/PORT/4.0/fix-sessions-issue branch from 0afd464 to fbb4bb4 Compare March 11, 2021 18:47
Session support check is now performed after server selection
this ensures the monitor was able to update the topology description

NODE-3100
@nbbeeken nbbeeken force-pushed the NODE-3100/PORT/4.0/fix-sessions-issue branch from fbb4bb4 to 9d10de4 Compare March 11, 2021 20:30
Comment on lines +51 to +52
// TODO: Each operation defines its own options, there should be better typing here
options: Document;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary type information for executeWithServerSelection

@nbbeeken nbbeeken requested review from emadum and durran March 11, 2021 20:59
@nbbeeken nbbeeken marked this pull request as ready for review March 11, 2021 21:00
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit c19f296 into 4.0 Mar 17, 2021
@nbbeeken nbbeeken deleted the NODE-3100/PORT/4.0/fix-sessions-issue branch March 17, 2021 14:56
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
Session support check is now performed after server selection
this ensures the monitor was able to update the topology description

NODE-3100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants