Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert BSON Map export removal #2704

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 15, 2021

Good news! Our mongosh early warning system works!
Looks like I dropped the Map export from BSON by mistake, here's the fix.

@nbbeeken nbbeeken marked this pull request as ready for review January 15, 2021 16:21
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 2b74387 into master Jan 19, 2021
@nbbeeken nbbeeken deleted the fix/revert-map-export-removal branch January 19, 2021 15:26
@addaleax
Copy link
Contributor

@nbbeeken Fwiw, we already worked around this in mongodb-js/mongosh@39e6dfb – you can keep these dropped if that’s what you prefer for 4.0.

@nbbeeken
Copy link
Contributor Author

Thanks for the heads up! I think we want to keep it until it would be removed from the BSON lib in it's major version, despite it not being the most useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants