-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(collection): only send bypassDocumentValidation if true
The bypassDocumentValidation key will only be set if it explicitly receives a true, otherwise it remains undefined. Fixes NODE-1492
- Loading branch information
Sophie Saskin
authored
Jun 18, 2018
1 parent
b3ff3ed
commit fdb828b
Showing
6 changed files
with
260 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,239 @@ | ||
| 'use strict'; | ||
|
|
||
| const MongoClient = require('../..').MongoClient; | ||
| const expect = require('chai').expect; | ||
| const mock = require('mongodb-mock-server'); | ||
|
|
||
| describe('bypass document validation', function() { | ||
| const test = {}; | ||
| beforeEach(() => { | ||
| return mock.createServer().then(server => { | ||
| test.server = server; | ||
| }); | ||
| }); | ||
| afterEach(() => mock.cleanup()); | ||
|
|
||
| // general test for aggregate function | ||
| function testAggregate(config, done) { | ||
| const client = new MongoClient(`mongodb://${test.server.uri()}/test`); | ||
| let close = e => { | ||
| close = () => {}; | ||
| client.close(() => done(e)); | ||
| }; | ||
|
|
||
| test.server.setMessageHandler(request => { | ||
| const doc = request.document; | ||
| if (doc.aggregate) { | ||
| try { | ||
| expect(doc.bypassDocumentValidation).equal(config.expected); | ||
| request.reply({ | ||
| ok: 1, | ||
| cursor: { | ||
| firstBatch: [{}], | ||
| id: 23, | ||
| ns: 'test.test' | ||
| } | ||
| }); | ||
| } catch (e) { | ||
| close(e); | ||
| } | ||
| } | ||
|
|
||
| if (doc.ismaster) { | ||
| request.reply(Object.assign({}, mock.DEFAULT_ISMASTER)); | ||
| } else if (doc.endSessions) { | ||
| request.reply({ ok: 1 }); | ||
| } | ||
| }); | ||
|
|
||
| client.connect(function(err, client) { | ||
| expect(err).to.not.exist; | ||
| const db = client.db('test'); | ||
| const collection = db.collection('test_c'); | ||
|
|
||
| const options = { bypassDocumentValidation: config.actual }; | ||
|
|
||
| const pipeline = [ | ||
| { | ||
| $project: {} | ||
| } | ||
| ]; | ||
| collection.aggregate(pipeline, options).next(() => close()); | ||
| }); | ||
| } | ||
| // aggregate | ||
| it('should only set bypass document validation if strictly true in aggregate', function(done) { | ||
| testAggregate({ expected: true, actual: true }, done); | ||
| }); | ||
|
|
||
| it('should not set bypass document validation if not strictly true in aggregate', function(done) { | ||
| testAggregate({ expected: undefined, actual: false }, done); | ||
| }); | ||
|
|
||
| // general test for mapReduce function | ||
| function testMapReduce(config, done) { | ||
| const client = new MongoClient(`mongodb://${test.server.uri()}/test`); | ||
| let close = e => { | ||
| close = () => {}; | ||
| client.close(() => done(e)); | ||
| }; | ||
|
|
||
| test.server.setMessageHandler(request => { | ||
| const doc = request.document; | ||
| if (doc.mapreduce) { | ||
| try { | ||
| expect(doc.bypassDocumentValidation).equal(config.expected); | ||
| request.reply({ | ||
| results: 't', | ||
| ok: 1 | ||
| }); | ||
| } catch (e) { | ||
| close(e); | ||
| } | ||
| } | ||
|
|
||
| if (doc.ismaster) { | ||
| request.reply(Object.assign({}, mock.DEFAULT_ISMASTER)); | ||
| } else if (doc.endSessions) { | ||
| request.reply({ ok: 1 }); | ||
| } | ||
| }); | ||
|
|
||
| client.connect(function(err, client) { | ||
| expect(err).to.not.exist; | ||
| const db = client.db('test'); | ||
| const collection = db.collection('test_c'); | ||
|
|
||
| const options = { | ||
| out: 'test_c', | ||
| bypassDocumentValidation: config.actual | ||
| }; | ||
|
|
||
| collection.mapReduce(function map() {}, function reduce() {}, options, e => { | ||
| close(e); | ||
| }); | ||
| }); | ||
| } | ||
| // map reduce | ||
| it('should only set bypass document validation if strictly true in mapReduce', function(done) { | ||
| testMapReduce({ expected: true, actual: true }, done); | ||
| }); | ||
|
|
||
| it('should not set bypass document validation if not strictly true in mapReduce', function(done) { | ||
| testMapReduce({ expected: undefined, actual: false }, done); | ||
| }); | ||
|
|
||
| // general test for findAndModify function | ||
| function testFindAndModify(config, done) { | ||
| const client = new MongoClient(`mongodb://${test.server.uri()}/test`); | ||
| let close = e => { | ||
| close = () => {}; | ||
| client.close(() => done(e)); | ||
| }; | ||
|
|
||
| test.server.setMessageHandler(request => { | ||
| const doc = request.document; | ||
| if (doc.findAndModify) { | ||
| try { | ||
| expect(doc.bypassDocumentValidation).equal(config.expected); | ||
| request.reply({ | ||
| ok: 1 | ||
| }); | ||
| } catch (e) { | ||
| close(e); | ||
| } | ||
| } | ||
|
|
||
| if (doc.ismaster) { | ||
| request.reply(Object.assign({}, mock.DEFAULT_ISMASTER)); | ||
| } else if (doc.endSessions) { | ||
| request.reply({ ok: 1 }); | ||
| } | ||
| }); | ||
|
|
||
| client.connect(function(err, client) { | ||
| expect(err).to.not.exist; | ||
| const db = client.db('test'); | ||
| const collection = db.collection('test_c'); | ||
|
|
||
| const options = { bypassDocumentValidation: config.actual }; | ||
|
|
||
| collection.findAndModify( | ||
| { name: 'Andy' }, | ||
| { rating: 1 }, | ||
| { $inc: { score: 1 } }, | ||
| options, | ||
| e => { | ||
| close(e); | ||
| } | ||
| ); | ||
| }); | ||
| } | ||
| // find and modify | ||
| it('should only set bypass document validation if strictly true in findAndModify', function(done) { | ||
| testFindAndModify({ expected: true, actual: true }, done); | ||
| }); | ||
|
|
||
| it('should not set bypass document validation if not strictly true in findAndModify', function(done) { | ||
| testFindAndModify({ expected: undefined, actual: false }, done); | ||
| }); | ||
|
|
||
| // general test for BlukWrite to test changes made in ordered.js and unordered.js | ||
| function testBulkWrite(config, done) { | ||
| const client = new MongoClient(`mongodb://${test.server.uri()}/test`); | ||
| let close = e => { | ||
| close = () => {}; | ||
| client.close(() => done(e)); | ||
| }; | ||
|
|
||
| test.server.setMessageHandler(request => { | ||
| const doc = request.document; | ||
| if (doc.insert) { | ||
| try { | ||
| expect(doc.bypassDocumentValidation).equal(config.expected); | ||
| request.reply({ | ||
| ok: 1 | ||
| }); | ||
| } catch (e) { | ||
| close(e); | ||
| } | ||
| } | ||
|
|
||
| if (doc.ismaster) { | ||
| request.reply(Object.assign({}, mock.DEFAULT_ISMASTER)); | ||
| } else if (doc.endSessions) { | ||
| request.reply({ ok: 1 }); | ||
| } | ||
| }); | ||
|
|
||
| client.connect(function(err, client) { | ||
| expect(err).to.not.exist; | ||
| const db = client.db('test'); | ||
| const collection = db.collection('test_c'); | ||
|
|
||
| const options = { | ||
| bypassDocumentValidation: config.actual, | ||
| ordered: config.ordered | ||
| }; | ||
|
|
||
| collection.bulkWrite([{ insertOne: { document: { a: 1 } } }], options, () => close()); | ||
| }); | ||
| } | ||
| // ordered bulk write, testing change in ordered.js | ||
| it('should only set bypass document validation if strictly true in ordered bulkWrite', function(done) { | ||
| testBulkWrite({ expected: true, actual: true, ordered: true }, done); | ||
| }); | ||
|
|
||
| it('should not set bypass document validation if not strictly true in ordered bulkWrite', function(done) { | ||
| testBulkWrite({ expected: undefined, actual: false, ordered: true }, done); | ||
| }); | ||
|
|
||
| // unordered bulk write, testing change in ordered.js | ||
| it('should only set bypass document validation if strictly true in unordered bulkWrite', function(done) { | ||
| testBulkWrite({ expected: true, actual: true, ordered: false }, done); | ||
| }); | ||
|
|
||
| it('should not set bypass document validation if not strictly true in unordered bulkWrite', function(done) { | ||
| testBulkWrite({ expected: undefined, actual: false, ordered: false }, done); | ||
| }); | ||
| }); |