code review feedback

src/bulk/common.ts

@@ -655,7 +655,7 @@ function handleMongoWriteConcernError(
 ) {
   mergeBatchResults(batch, bulkResult, undefined, err.result);
 
-  // TODO: make more reasonable
+  // TODO: Remove multiple levels of wrapping (NODE-3337)
   const wrappedWriteConcernError = new WriteConcernError(
     new MongoServerError({
       errmsg: err.result?.writeConcernError.errmsg,

src/collection.ts

@@ -1399,6 +1399,7 @@ export class Collection<TSchema extends Document = Document> {
   ): Promise<Document | Document[]> | void {
     if ('function' === typeof options) (callback = options), (options = {});
     // Out must always be defined (make sure we don't break weirdly on pre 1.8+ servers)
+    // TODO NODE-3339: Figure out if this is still necessary given we no longer officially support pre-1.8
     if (options?.out == null) {
       throw new MongoDriverError(
         'the out option parameter must be defined, see mongodb docs for possible values'

src/gridfs-stream/download.ts

@@ -195,9 +195,7 @@ export class GridFSBucketReadStream extends Readable {
 
 function throwIfInitialized(stream: GridFSBucketReadStream): void {
   if (stream.s.init) {
-    throw new MongoDriverError(
-      'You cannot change options after the stream has entered flowing mode!'
-    );
+    throw new MongoDriverError('Options cannot be changed after the stream is initialized');
   }
 }
 
@@ -316,7 +314,7 @@ function init(stream: GridFSBucketReadStream): void {
         : stream.s.filter.filename;
       const errmsg = 'FileNotFound: file ' + identifier + ' was not found';
       const err = new MongoDriverError(errmsg);
-      err.code = 'ENOENT';
+      err.code = 'ENOENT'; // TODO: NODE-3338 set property as part of constructor
       return __handleError(stream, err);
     }
 

src/operations/eval.ts

@@ -68,7 +68,7 @@ export class EvalOperation extends CommandOperation<Document> {
       }
 
       if (result) {
-        callback(new MongoServerError({ message: `eval failed: ${result.errmsg}`, driver: true }));
+        callback(new MongoServerError({ message: `eval failed: ${result.errmsg}` }));
         return;
       }
 

src/sessions.ts

@@ -774,7 +774,7 @@ function applySession(
 ): MongoDriverError | undefined {
   // TODO: merge this with `assertAlive`, did not want to throw a try/catch here
   if (session.hasEnded) {
-    return new MongoDriverError('Attemped to use a session that has ended');
+    return new MongoDriverError('Attempted to use a session that has ended');
   }
 
   const serverSession = session.serverSession;