From 22a4628abf935d0bf46a26897ddceb96e0640d47 Mon Sep 17 00:00:00 2001
From: daprahamian <dan.aprahamian@gmail.com>
Date: Fri, 17 Nov 2017 13:02:40 -0500
Subject: [PATCH] fix(GridFS):  fix TypeError: doc.data.length is not a
 function (#1570)

This is a port of #1555 to 3.0.0 branch.
When using the promoteBuffers connect option, `doc.data` is already a node.js Buffer.
So trying to call `length()` like for `BSON.Binary` fails.
Fixed simply by checking `Buffer.isBuffer(doc.data)` type.
---
 lib/gridfs-stream/download.js | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/lib/gridfs-stream/download.js b/lib/gridfs-stream/download.js
index 54ede4f332..87db72b27d 100644
--- a/lib/gridfs-stream/download.js
+++ b/lib/gridfs-stream/download.js
@@ -207,29 +207,27 @@ function doRead(_this) {
       return __handleError(_this, new Error(errmsg));
     }
 
-    if (doc.data.length() !== expectedLength) {
+    var buf = Buffer.isBuffer(doc.data) ? doc.data : doc.data.buffer;
+
+    if (buf.length !== expectedLength) {
       if (bytesRemaining <= 0) {
         errmsg = 'ExtraChunk: Got unexpected n: ' + doc.n;
         return __handleError(_this, new Error(errmsg));
       }
 
       errmsg =
-        'ChunkIsWrongSize: Got unexpected length: ' +
-        doc.data.length() +
-        ', expected: ' +
-        expectedLength;
+        'ChunkIsWrongSize: Got unexpected length: ' + buf.length + ', expected: ' + expectedLength;
       return __handleError(_this, new Error(errmsg));
     }
 
-    _this.s.bytesRead += doc.data.length();
+    _this.s.bytesRead += buf.length;
 
-    if (doc.data.buffer.length === 0) {
+    if (buf.length === 0) {
       return _this.push(null);
     }
 
     var sliceStart = null;
     var sliceEnd = null;
-    var buf = doc.data.buffer;
 
     if (_this.s.bytesToSkip != null) {
       sliceStart = _this.s.bytesToSkip;
@@ -241,7 +239,7 @@ function doRead(_this) {
     }
 
     // If the remaining amount of data left is < chunkSize read the right amount of data
-    if (_this.s.options.end && _this.s.options.end - _this.s.bytesToSkip < doc.data.length()) {
+    if (_this.s.options.end && _this.s.options.end - _this.s.bytesToSkip < buf.length) {
       sliceEnd = _this.s.options.end - _this.s.bytesToSkip;
     }