MONGOID-5819 Do not pass the :database option when creating a client #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option is already accounted for via the `#use` method.
comandeo-mongo
approved these changes
Oct 21, 2024
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Oct 21, 2024
…ongodb#5886) * MONGOID-5819 Do not pass the :database option when creating a client The option is already accounted for via the `#use` method. * fix failing specs
jamis
added a commit
that referenced
this pull request
Oct 22, 2024
…5886) (#5890) * MONGOID-5819 Do not pass the :database option when creating a client The option is already accounted for via the `#use` method. * fix failing specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MONGOID-5472 was implemented (to enable models to remember the persistence context that was active when they were saved), it changed how storage options are interpreted in Mongoid. One overlooked pre-existing feature, however, was the ability to pass a Proc as the database name, and the new code did not account for that.
This PR updates the persistence context so that when a new client is instantiated, it does not receive the
:databaseoption (which was previously accounted for by callingclient.useinstead). This prevents the Proc-valued:databaseoption from being reinterpreted as a String by the client, which was causing errors because the resulting "name" was not valid.(Note: this will need to be backported to 9.0-stable.)