GODRIVER-2323 Support int64 for 'n' field in insert, update, and delete ops. #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Should we add a similar type switch in count.go to not error on the receiving of an int32 from the server?
|
There are also some lint failures for now unnecessary conversions to |
prestonvasquez
approved these changes
Apr 8, 2022
|
@benjirewis Added int32 support to |
kevinAlbs
reviewed
Apr 11, 2022
benjirewis
approved these changes
Apr 11, 2022
matthewdale
force-pushed
the
godriver2323-support-int64
branch
from
e2cbbb2 to
a1702ee
Compare
matthewdale
added a commit
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2323
Add support for int32 and int64 types in the
"n"and"nModified"fields in various server CRUD responses.