Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-41336: documentmodel trait #3065

Merged
merged 1 commit into from
Jul 23, 2024
Merged

DOCSP-41336: documentmodel trait #3065

merged 1 commit into from
Jul 23, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jul 22, 2024 •
edited
Loading

Adds documentation for documentmodel trait

https://jira.mongodb.org/browse/DOCSP-41336
STAGING

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@github-actions github-actions bot added the docs label Jul 22, 2024
@rustagir rustagir marked this pull request as ready for review July 22, 2024 18:19
@rustagir rustagir requested a review from a team as a code owner July 22, 2024 18:19
@rustagir rustagir requested a review from GromNaN July 22, 2024 18:19
mongoKart
mongoKart approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small changes but LGTM otherwise

docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
docs/eloquent-models/model-class.txt Outdated Show resolved Hide resolved
@rustagir rustagir requested a review from GromNaN July 23, 2024 14:16
GromNaN
GromNaN approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rustagir rustagir changed the base branch from 4.8 to 4.6 July 23, 2024 14:24
@rustagir rustagir requested a review from a team as a code owner July 23, 2024 14:24
@rustagir rustagir requested review from alcaeus and removed request for alcaeus July 23, 2024 14:24
@rustagir rustagir force-pushed the DOCSP-41336-documentmodel-trait branch from 14b3b3f to eabde02 Compare July 23, 2024 14:27
@rustagir rustagir force-pushed the DOCSP-41336-documentmodel-trait branch from eabde02 to 8b0b270 Compare July 23, 2024 14:33
@rustagir rustagir closed this Jul 23, 2024
@rustagir rustagir reopened this Jul 23, 2024
@rustagir rustagir enabled auto-merge (squash) July 23, 2024 14:39
@rustagir rustagir merged commit b0c3a95 into mongodb:4.6 Jul 23, 2024
51 checks passed
This was referenced Jul 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mongoKart mongoKart mongoKart approved these changes

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @GromNaN @mongoKart