Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HowTo] Rebasing PRs #937

Closed
pi0 opened this issue Sep 1, 2016 · 1 comment
Closed

[HowTo] Rebasing PRs #937

pi0 opened this issue Sep 1, 2016 · 1 comment

Comments

@pi0
Copy link
Contributor

pi0 commented Sep 1, 2016

There are new breaking changes on master so all UnitTests was failing on PRs.

In order to rebase your forks with master branch and running UnitTests against latest changes you can follow this steps.
Assuming we want to rebase #918 (fieteboerner:aggregate-subdocument). on your fork :

# Add upstream and fetch everything
git remote add upstream [email protected]:jenssegers/laravel-mongodb.git
git fetch upstream

# Checkout to patch branch
git checkout aggregate-subdocument

# Rebase with upstream's master
git rebase upstream/master

# Fast-Forward Changes
git push -ff

Then you can check your PR again for failing tests and fix them :)

@Bodom78
Copy link
Contributor

Bodom78 commented Sep 2, 2016

Thanks @pi0, I have followed your instructions and #792 is now passing all checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants