perf(NODE-6126): improve Long.fromBigInt performance #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chose BigInt Constructor because it is 7.2% better than the 10,000 iterations case for FromString/ToString, and 1.4% improvement from the BigInt Literal case |
aditi-khare-mongoDB
force-pushed
the
NODE-6126/long-fromBigInt-perf
branch
from
40558e0
to
e6d2fb9
Compare
nbbeeken
requested changes
May 6, 2024
nbbeeken
added
the
Primary Review
aditi-khare-mongoDB
force-pushed
the
NODE-6126/long-fromBigInt-perf
branch
from
7bc046f
to
34dc671
Compare
nbbeeken
requested changes
May 7, 2024
nbbeeken
approved these changes
May 7, 2024
nbbeeken
added
Team Review
W-A-James
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
Long.fromBigIntto only use bit math, and refactor theLongconstructor to have cleaner logic + removeObject.assigncallsWhat is changing?
Improve performance of
Long.fromBigIntIs there new documentation needed for these changes?
No.
What is the motivation for this change?
Use a more efficient algorithm for
Long.fromBigIntRelease Highlight
Optimize performance of
Long.fromBigIntInternally fromBigInt was originally implemented using toString of the bigint value. Now,
Long.fromBigInthas been refactored to use bitwise operations greatly improving performance.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript