fix(NODE-6042): Binary.toString output with respect to position #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Binary.toString
andBinary.toJSON
now respect position when printing out binary object.What is changing?
See release highlights.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Bug Fix.
Release Highlight
Binary.toString
andBinary.toJSON
now respect position when printing out binary object.When the
toString()
ortoJSON
method is called on aBinary
instance, it will print out until the instance's position property of the object, instead of the entire buffer.Example:
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript